Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8a898162 authored by Pavlin Radoslavov's avatar Pavlin Radoslavov
Browse files

Base classes should have virtual destructors 

Each base class in service/common/bluetooth now has a virtual
destructor. This fixes memory delete issues that were exposed
when running the unit tests with ASAN enabled.

Test: Running unit tests with ASAN enabled
Change-Id: Ie944eb80784de4ebac3c7276fabed6acb5fec6c0
parent 1ca983f9

system/service/common/bluetooth/advertise_data.h

+1 −1
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ class AdvertiseData { 
  // Default constructor initializes all fields to be empty/false.

  AdvertiseData();

  AdvertiseData(const AdvertiseData& other);

  ~AdvertiseData() = default;

  virtual ~AdvertiseData() = default;



  // Returns true if the advertising data is formatted correctly according to

  // the TLV format.

system/service/common/bluetooth/advertise_settings.h

+1 −1
Original line number Diff line number Diff line
@@ -69,7 +69,7 @@ class AdvertiseSettings { 
  //   TX power level: TX_POWER_LEVEL_MEDIUM

  //   connectable: true

  AdvertiseSettings();

  ~AdvertiseSettings() = default;

  virtual ~AdvertiseSettings() = default;



  // Returns the advertise mode.

  Mode mode() const { return mode_; }

system/service/common/bluetooth/characteristic.h

+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ class Characteristic { 
        permissions_(permissions),

        descriptors_(descriptors){};

  Characteristic& operator=(const Characteristic& other);

  ~Characteristic() = default;

  virtual ~Characteristic() = default;



  // Comparison function and operator.

  bool Equals(const Characteristic& other) const;

system/service/common/bluetooth/descriptor.h

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ class Descriptor { 
  Descriptor& operator=(const Descriptor& other);

  Descriptor(uint16_t handle, const UUID& uuid, uint16_t permissions)

      : handle_(handle), uuid_(uuid), permissions_(permissions){};

  ~Descriptor() = default;

  virtual ~Descriptor() = default;



  // Comparison function and operator.

  bool Equals(const Descriptor& other) const;

system/service/common/bluetooth/scan_filter.h

+1 −1
Original line number Diff line number Diff line
@@ -27,7 +27,7 @@ namespace bluetooth { 
class ScanFilter {

 public:

  ScanFilter() = default;

  ~ScanFilter() = default;

  virtual ~ScanFilter() = default;



  // Copy constructor and assignment operator.

  ScanFilter(const ScanFilter& other);