Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 89291600 authored by Łukasz Rymanowski's avatar Łukasz Rymanowski
Browse files

leaudio: Fix unit test verifier 

This fixes mock verifier.

Bug: 325627564
Test: atest bluetooth_le_audio_test
Flags: Exempt, test only fix
Change-Id: I2c257af8e0e5beee415c0dbe3c0f60051ff106f0
parent fb721fae

system/bta/le_audio/state_machine_test.cc

+45 −36
Original line number Diff line number Diff line
@@ -1885,7 +1885,7 @@ TEST_F(StateMachineTest, testConfigureQosFailed) { 
  ASSERT_EQ(group->GetState(), types::AseState::BTA_LE_AUDIO_ASE_STATE_IDLE);

  ASSERT_EQ(2, get_func_call_count("alarm_cancel"));



  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);

}



TEST_F(StateMachineTest, testStreamCreationError) {
@@ -3683,7 +3683,6 @@ TEST_F(StateMachineTest, testReleaseMultiple_DeviceDisconnectedDuringRelease) { 
  EXPECT_CALL(*mock_iso_manager_, SetupIsoDataPath(_, _)).Times(2);

  EXPECT_CALL(*mock_iso_manager_, RemoveIsoDataPath(_, _)).Times(0);

  EXPECT_CALL(*mock_iso_manager_, DisconnectCis(_, _)).Times(0);

  EXPECT_CALL(*mock_iso_manager_, RemoveCig(_, _)).Times(1);



  InjectInitialIdleNotification(group);
@@ -3705,8 +3704,9 @@ TEST_F(StateMachineTest, testReleaseMultiple_DeviceDisconnectedDuringRelease) { 
  ASSERT_EQ(1, get_func_call_count("alarm_cancel"));

  reset_mock_function_count_map();



  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  EXPECT_CALL(*mock_iso_manager_, RemoveCig(_, _)).Times(1);

  // Validate GroupStreamStatus

  EXPECT_CALL(

      mock_callbacks_,
@@ -3723,7 +3723,7 @@ TEST_F(StateMachineTest, testReleaseMultiple_DeviceDisconnectedDuringRelease) { 
  // Stop the stream

  LeAudioGroupStateMachine::Get()->StopStream(group);



  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(), types::AseState::BTA_LE_AUDIO_ASE_STATE_IDLE);
@@ -4719,7 +4719,7 @@ TEST_F(StateMachineTest, testAttachDeviceToTheStream) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  // Inject CIS and ACL disconnection of first device

  InjectCisDisconnected(group, lastDevice, HCI_ERR_CONNECTION_TOUT);
@@ -4835,7 +4835,7 @@ TEST_F(StateMachineTest, testAttachDeviceToTheStreamV2) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  // Inject CIS and ACL disconnection of first device

  InjectCisDisconnected(group, lastDevice, HCI_ERR_CONNECTION_TOUT);
@@ -4950,7 +4950,7 @@ TEST_F(StateMachineTest, testAttachDeviceToTheStreamDeviceNoAvailableContext) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  // Inject CIS and ACL disconnection of first device

  InjectCisDisconnected(group, lastDevice, HCI_ERR_CONNECTION_TOUT);
@@ -5058,7 +5058,7 @@ TEST_F(StateMachineTest, testAutonomousConfiguredAndAttachToStream) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  // Inject CIS and ACL disconnection of first device

  InjectCisDisconnected(group, lastDevice, HCI_ERR_CONNECTION_TOUT);
@@ -5199,7 +5199,7 @@ TEST_F(StateMachineTest, 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  // Inject CIS and ACL disconnection of first device

  InjectCisDisconnected(group, lastDevice, HCI_ERR_CONNECTION_TOUT);
@@ -5298,7 +5298,7 @@ TEST_F(StateMachineTest, testAttachDeviceToTheStreamDoNotAttach) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  // Check if group keeps streaming

  ASSERT_EQ(group->GetState(),
@@ -5370,7 +5370,7 @@ TEST_F(StateMachineTest, testReconfigureAfterLateDeviceAttached) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  /* Stop  the stream and let first device to stay in configured state (caching

   * is on)*/
@@ -5486,7 +5486,7 @@ TEST_F(StateMachineTest, testStreamToGettingReadyDevice) { 
  // being in the `CONNECTED_BY_USER_GETTING_READY` state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);

}



TEST_F(StateMachineTest, testAttachDeviceToTheConversationalStream) {
@@ -5578,7 +5578,7 @@ TEST_F(StateMachineTest, testAttachDeviceToTheConversationalStream) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  // Verify data path removal on the second bidirectional CIS

  EXPECT_CALL(
@@ -5592,7 +5592,7 @@ TEST_F(StateMachineTest, testAttachDeviceToTheConversationalStream) { 
  // Inject CIS and ACL disconnection of first device

  InjectCisDisconnected(group, lastDevice, HCI_ERR_CONNECTION_TOUT);

  InjectAclDisconnected(group, lastDevice);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  // Check if group keeps streaming

  ASSERT_EQ(group->GetState(),
@@ -5890,7 +5890,7 @@ TEST_F(StateMachineTest, StartStreamCachedConfigReconfigInvalidBehavior) { 
  LeAudioGroupStateMachine::Get()->StopStream(group);



  testing::Mock::VerifyAndClearExpectations(&mock_callbacks_);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  ASSERT_EQ(1, get_func_call_count("alarm_cancel"));

  reset_mock_function_count_map();
@@ -5933,7 +5933,7 @@ TEST_F(StateMachineTest, StartStreamCachedConfigReconfigInvalidBehavior) { 
  ASSERT_FALSE(result);



  testing::Mock::VerifyAndClearExpectations(&mock_callbacks_);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);

}



TEST_F(StateMachineTest, BoundedHeadphonesConversationalToMediaChannelCount_2) {
@@ -6183,7 +6183,7 @@ TEST_F(StateMachineTest, lateCisDisconnectedEvent_DuringReconfiguration) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  ASSERT_EQ(1, get_func_call_count("alarm_cancel"));

  reset_mock_function_count_map();
@@ -6273,7 +6273,7 @@ TEST_F(StateMachineTest, lateCisDisconnectedEvent_AutonomousConfigured) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  ASSERT_EQ(1, get_func_call_count("alarm_cancel"));

  reset_mock_function_count_map();
@@ -6366,7 +6366,7 @@ TEST_F(StateMachineTest, lateCisDisconnectedEvent_Idle) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  ASSERT_EQ(1, get_func_call_count("alarm_cancel"));

  reset_mock_function_count_map();
@@ -6422,12 +6422,10 @@ TEST_F(StateMachineTest, StreamReconfigureAfterCisLostTwoDevices) { 
  /* Prepare DisconnectCis mock to not symulate CisDisconnection */

  ON_CALL(*mock_iso_manager_, DisconnectCis).WillByDefault(Return());



  EXPECT_CALL(*mock_iso_manager_, CreateCig(_, _)).Times(2);

  EXPECT_CALL(*mock_iso_manager_, EstablishCis(_)).Times(2);

  EXPECT_CALL(*mock_iso_manager_, SetupIsoDataPath(_, _)).Times(6);

  EXPECT_CALL(*mock_iso_manager_, RemoveIsoDataPath(_, _)).Times(2);

  EXPECT_CALL(*mock_iso_manager_, CreateCig(_, _)).Times(1);

  EXPECT_CALL(*mock_iso_manager_, EstablishCis(_)).Times(1);

  EXPECT_CALL(*mock_iso_manager_, SetupIsoDataPath(_, _)).Times(2);

  EXPECT_CALL(*mock_iso_manager_, DisconnectCis(_, _)).Times(0);

  EXPECT_CALL(*mock_iso_manager_, RemoveCig(_, _)).Times(1);



  InjectInitialIdleNotification(group);
@@ -6461,10 +6459,16 @@ TEST_F(StateMachineTest, StreamReconfigureAfterCisLostTwoDevices) { 
  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  ASSERT_EQ(1, get_func_call_count("alarm_cancel"));

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(&gatt_queue);

  testing::Mock::VerifyAndClearExpectations(&mock_callbacks_);



  EXPECT_CALL(*mock_iso_manager_, CreateCig(_, _)).Times(1);

  EXPECT_CALL(*mock_iso_manager_, EstablishCis(_)).Times(1);

  EXPECT_CALL(*mock_iso_manager_, SetupIsoDataPath(_, _)).Times(4);

  EXPECT_CALL(*mock_iso_manager_, RemoveIsoDataPath(_, _)).Times(2);

  EXPECT_CALL(*mock_iso_manager_, RemoveCig(_, _)).Times(1);



  // Device disconnects due to timeout of CIS

  leAudioDevice = group->GetFirstDevice();

  while (leAudioDevice) {
@@ -6523,7 +6527,7 @@ TEST_F(StateMachineTest, StreamReconfigureAfterCisLostTwoDevices) { 
  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  ASSERT_EQ(2, get_func_call_count("alarm_cancel"));

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(&gatt_queue);

  testing::Mock::VerifyAndClearExpectations(&mock_callbacks_);

}
@@ -6607,7 +6611,7 @@ TEST_F(StateMachineTest, StreamClearAfterReleaseAndConnectionTimeout) { 
  InjectAclDisconnected(group, lastDevice);



  testing::Mock::VerifyAndClearExpectations(&mock_callbacks_);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);

}



TEST_F(StateMachineTest, VerifyThereIsNoDoubleDataPathRemoval) {
@@ -6677,7 +6681,7 @@ TEST_F(StateMachineTest, VerifyThereIsNoDoubleDataPathRemoval) { 
  LeAudioGroupStateMachine::Get()->StopStream(group);



  testing::Mock::VerifyAndClearExpectations(&mock_callbacks_);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);

}



TEST_F(StateMachineTest, StreamStartWithDifferentContextFromConfiguredState) {
@@ -6897,7 +6901,7 @@ TEST_F(StateMachineTest, testAttachDeviceToTheStreamCisFailure) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  // Inject CIS and ACL disconnection of first device

  InjectCisDisconnected(group, lastDevice, HCI_ERR_CONNECTION_TOUT);
@@ -7009,7 +7013,7 @@ TEST_F(StateMachineTest, testAclDropWithoutApriorCisDisconnection) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  /* Separate CIS  for dual CIS device is treated as sink device */

  ASSERT_EQ(group->stream_conf.stream_params.sink.num_of_devices, 2);
@@ -7068,7 +7072,6 @@ TEST_F(StateMachineTest, testAutonomousDisableTimeout) { 


  EXPECT_CALL(*mock_iso_manager_, CreateCig(_, _)).Times(1);

  EXPECT_CALL(*mock_iso_manager_, EstablishCis(_)).Times(1);

  EXPECT_CALL(*mock_iso_manager_, RemoveIsoDataPath(_, _)).Times(1);

  EXPECT_CALL(*mock_iso_manager_, SetupIsoDataPath(_, _)).Times(4);



  InjectInitialIdleNotification(group);
@@ -7085,7 +7088,10 @@ TEST_F(StateMachineTest, testAutonomousDisableTimeout) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);



  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  EXPECT_CALL(*mock_iso_manager_, RemoveIsoDataPath(_, _)).Times(1);



  /* First timer finished when group achieves streaming state */

  ASSERT_EQ(1, get_func_call_count("alarm_cancel"));
@@ -7109,6 +7115,7 @@ TEST_F(StateMachineTest, testAutonomousDisableTimeout) { 
              OnDeviceAutonomousStateTransitionTimeout(lastDevice));



  fake_osi_alarm_set_on_mloop_.cb(fake_osi_alarm_set_on_mloop_.data);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);

}



TEST_F(StateMachineTest, testAutonomousDisableSuccess) {
@@ -7153,7 +7160,6 @@ TEST_F(StateMachineTest, testAutonomousDisableSuccess) { 


  EXPECT_CALL(*mock_iso_manager_, CreateCig(_, _)).Times(1);

  EXPECT_CALL(*mock_iso_manager_, EstablishCis(_)).Times(1);

  EXPECT_CALL(*mock_iso_manager_, RemoveIsoDataPath(_, _)).Times(1);

  EXPECT_CALL(*mock_iso_manager_, SetupIsoDataPath(_, _)).Times(4);



  InjectInitialIdleNotification(group);
@@ -7170,7 +7176,10 @@ TEST_F(StateMachineTest, testAutonomousDisableSuccess) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);



  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  EXPECT_CALL(*mock_iso_manager_, RemoveIsoDataPath(_, _)).Times(1);



  /* Remote initiates autonomous Disable operation */

  auto ase_sink = lastDevice->GetFirstActiveAseByDirection(
@@ -7201,7 +7210,7 @@ TEST_F(StateMachineTest, testAutonomousDisableSuccess) { 
   * to STREAMING state and connect CISes again.

   */

  InjectCisDisconnected(group, lastDevice, HCI_ERR_CONNECTION_TOUT, true);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  /* Check if autonomous operation timer is freed */

  ASSERT_EQ(1, get_func_call_count("alarm_free"));
@@ -7265,7 +7274,7 @@ TEST_F(StateMachineTest, testAutonomousDisableCancelOnDisconnect) { 
  // Check if group has transitioned to a proper state

  ASSERT_EQ(group->GetState(),

            types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

  testing::Mock::VerifyAndClearExpectations(&mock_iso_manager_);

  testing::Mock::VerifyAndClearExpectations(mock_iso_manager_);



  /* First timer finished when group achieves streaming state */

  ASSERT_EQ(1, get_func_call_count("alarm_cancel"));