Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 81825246 authored by Martin Geisler's avatar Martin Geisler
Browse files

pdl: refactor “isinstance(…) or isinstance(…)” 

Python lets you check for multiple types with a single call.

Test: atest pdl_python_generator_test
Change-Id: I140fe9b3cf57a0e5f3f72c5957e892c6b3aaffcd
parent 0e385aee

tools/pdl/scripts/generate_python_backend.py

+1 −1
Original line number Original line Diff line number Diff line
@@ -447,7 +447,7 @@ class FieldParser: 
            self.parse_typedef_field_(field)

            self.parse_typedef_field_(field)





        # Payload and body fields.

        # Payload and body fields.

        elif (isinstance(field, ast.PayloadField) or isinstance(field, ast.BodyField)):

        elif isinstance(field, (ast.PayloadField, ast.BodyField)):

            self.parse_payload_field_(field)

            self.parse_payload_field_(field)





        # Checksum fields.

        # Checksum fields.

tools/pdl/scripts/pdl/ast.py

+1 −1
Original line number Original line Diff line number Diff line
@@ -241,7 +241,7 @@ class File: 
def convert_(obj: object) -> object:

def convert_(obj: object) -> object:

    if obj is None:

    if obj is None:

        return None

        return None

    if isinstance(obj, int) or isinstance(obj, str):

    if isinstance(obj, (int, str)):

        return obj

        return obj

    if isinstance(obj, list):

    if isinstance(obj, list):

        return [convert_(elt) for elt in obj]

        return [convert_(elt) for elt in obj]