Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 808397cb authored by Jakub Pawlowski's avatar Jakub Pawlowski
Browse files

Fix SMP_Encrypt for data shorter than 16 bytes 

This bug was introduced in commit 22c8a95a
osi_calloc was replaced with raw array, that is not wiped clean.

Change-Id: I57a4e7a26108ad4672d2dd2ff25028653c96ca1b
parent 5cd984db

system/stack/smp/smp_keys.cc

+1 −0
Original line number Diff line number Diff line
@@ -115,6 +115,7 @@ void smp_encrypt_data(BT_OCTET16 key, uint8_t* message, uint8_t length, 
  if (length > SMP_ENCRYT_DATA_SIZE) length = SMP_ENCRYT_DATA_SIZE;



  uint8_t p_start[SMP_ENCRYT_DATA_SIZE * 4];

  memset(p_start, 0, SMP_ENCRYT_DATA_SIZE * 4);

  p = p_start;

  ARRAY_TO_STREAM(p, message, length);             /* byte 0 to byte 15 */

  p_rev_data = p = p_start + SMP_ENCRYT_DATA_SIZE; /* start at byte 16 */