Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7fa07bb6 authored by Henri Chataing's avatar Henri Chataing
Browse files

gd: Remove logging for DELETE_STORED_LINK_KEY 

- The command is actually a no-op since the controller
  never saves link-keys to the key store by default
  and gd doesn't either

- gd never checks the supported command mask before sending
  the command, and the logger fails to parse the
  response when it has status UNKNOWN_OPCODE

Bug: 268254139
Test: NA
Change-Id: I52969de202242e5fba72062e2041dac3c58dc107
parent 5ef351ce

system/gd/hci/hci_metrics_logging.cc

+0 −14
Original line number Diff line number Diff line
@@ -794,14 +794,6 @@ void log_classic_pairing_command_status(std::unique_ptr<CommandView>& command_vi 
      value = static_cast<int64_t>(set_connection_encryption_view.GetEncryptionEnable());

      break;

    }

    case OpCode::DELETE_STORED_LINK_KEY: {

      DeleteStoredLinkKeyView delete_stored_link_key_view

      = DeleteStoredLinkKeyView::Create(std::move(security_command_view));

      ASSERT(delete_stored_link_key_view.IsValid());

      address = delete_stored_link_key_view.GetBdAddr();

      value = static_cast<int64_t>(delete_stored_link_key_view.GetDeleteAllFlag());

      break;

    }

    case OpCode::REMOTE_NAME_REQUEST: {

      RemoteNameRequestView remote_name_request_view = RemoteNameRequestView::Create(std::move(discovery_command_view));

      ASSERT(remote_name_request_view.IsValid());
@@ -930,12 +922,6 @@ void log_classic_pairing_command_complete(EventView event_view, std::unique_ptr< 
  ASSERT(security_command_view.IsValid());



  switch (op_code) {

    case OpCode::DELETE_STORED_LINK_KEY: {

      auto delete_stored_link_key_complete_view = DeleteStoredLinkKeyCompleteView::Create(std::move(command_complete_view));

      ASSERT(delete_stored_link_key_complete_view.IsValid());

      status = delete_stored_link_key_complete_view.GetStatus();

      break;

    }

    case OpCode::READ_LOCAL_OOB_DATA: {

      auto read_local_oob_data_complete_view = ReadLocalOobDataCompleteView::Create(std::move(command_complete_view));

      ASSERT(read_local_oob_data_complete_view.IsValid());