Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7d6d5303 authored by William Escande's avatar William Escande
Browse files

BluetoothApp: Enforce more error prone 2 

This fix & enforce:
* AlreadyChecked
* FallThrough
* LoopOverCharArray
* NarrowCalculation
* NonAtomicVolatileUpdate
* OperatorPrecedence
* ToStringReturnsNull
* UnrecognisedJavadocTag

Test: m Bluetooth
Flag: Exempt refactor
Bug: 344658662
Change-Id: I1034a481ebb909442cd083c4acc9763009b49820
parent 68abe535

android/app/Android.bp

+8 −0
Original line number Diff line number Diff line
@@ -323,6 +323,7 @@ android_app { 
        enabled: true,

        javacflags: [

            "-Xep:AlmostJavadoc:ERROR",

            "-Xep:AlreadyChecked:ERROR",

            "-Xep:AndroidFrameworkBinderIdentity:ERROR",

            "-Xep:AndroidFrameworkEfficientStrings:ERROR",

            "-Xep:AndroidFrameworkRequiresPermission:ERROR",
@@ -330,20 +331,27 @@ android_app { 
            "-Xep:ClassCanBeStatic:ERROR",

            "-Xep:DateFormatConstant:ERROR",

            "-Xep:EmptyBlockTag:ERROR",

            "-Xep:FallThrough:ERROR",

            "-Xep:HidingField:ERROR",

            "-Xep:InlineMeInliner:ERROR",

            "-Xep:InvalidBlockTag:ERROR",

            "-Xep:InvalidParam:ERROR",

            "-Xep:LoopOverCharArray:ERROR",

            "-Xep:MissingCasesInEnumSwitch:ERROR",

            "-Xep:MockNotUsedInProduction:ERROR",

            "-Xep:ModifyCollectionInEnhancedForLoop:ERROR",

            "-Xep:NarrowCalculation:ERROR",

            "-Xep:NonApiType:ERROR",

            "-Xep:NonAtomicVolatileUpdate:ERROR",

            "-Xep:NonCanonicalType:ERROR",

            "-Xep:NotJavadoc:ERROR",

            "-Xep:OperatorPrecedence:ERROR",

            "-Xep:ReturnAtTheEndOfVoidFunction:ERROR",

            "-Xep:StringCaseLocaleUsage:ERROR",

            "-Xep:StringCharset:ERROR",

            "-Xep:ToStringReturnsNull:ERROR",

            "-Xep:UnnecessaryStringBuilder:ERROR",

            "-Xep:UnrecognisedJavadocTag:ERROR",

            "-Xep:UnusedMethod:ERROR",

            "-Xep:UnusedNestedClass:ERROR",

            "-Xep:UnusedVariable:ERROR",

android/app/src/com/android/bluetooth/avrcpcontroller/AvrcpCoverArtManager.java

+2 −1
Original line number Diff line number Diff line
@@ -128,7 +128,8 @@ public class AvrcpCoverArtManager { 
     */

    public static boolean isValidImageHandle(String handle) {

        if (handle == null || handle.length() != 7) return false;

        for (char c : handle.toCharArray()) {

        for (int i = 0; i < handle.length(); i++) {

            char c = handle.charAt(i);

            if (!Character.isDigit(c)) {

                return false;

            }

android/app/src/com/android/bluetooth/avrcpcontroller/bip/BipDateTime.java

+3 −0
Original line number Diff line number Diff line
@@ -16,6 +16,8 @@ 


package com.android.bluetooth.avrcpcontroller;



import android.annotation.SuppressLint;



import com.android.bluetooth.Utils;



import java.util.Calendar;
@@ -121,6 +123,7 @@ public class BipDateTime { 
    }



    @Override

    @SuppressLint("ToStringReturnsNull")

    public String toString() {

        Date d = getTime();

        if (d == null) {

android/app/src/com/android/bluetooth/avrcpcontroller/bip/BipImageDescriptor.java

+2 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


package com.android.bluetooth.avrcpcontroller;



import android.annotation.SuppressLint;

import android.util.Log;

import android.util.Xml;
@@ -262,6 +263,7 @@ public class BipImageDescriptor { 
    }



    @Override

    @SuppressLint("ToStringReturnsNull") // Since this is used for encoding to xml

    public String toString() {

        if (mEncoding == null || mPixel == null) {

            error(

android/app/src/com/android/bluetooth/avrcpcontroller/bip/BipImageFormat.java

+2 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


package com.android.bluetooth.avrcpcontroller;



import android.annotation.SuppressLint;

import android.util.Log;



import java.util.Objects;
@@ -179,6 +180,7 @@ public class BipImageFormat { 
    }



    @Override

    @SuppressLint("ToStringReturnsNull") // Since this is used for encoding to xml

    public String toString() {

        if (mEncoding == null

                || mEncoding.getType() == BipEncoding.UNKNOWN