Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7aca3aef authored by Jakub Pawlowski's avatar Jakub Pawlowski
Browse files

HOGP: Preffer write command over write requests 

Some HID devices will accept both write request and write command.
Prefer write commands when possible.

This is due to bug in some hardware, that will not send write response
when too many commands are queued.

Bug: 29184976
Change-Id: I5bafc067f044a48f152c60b8e17722067bc1453e
parent f4dc23ee

system/bta/hh/bta_hh_le.c

+7 −3
Original line number Diff line number Diff line
@@ -2288,7 +2288,6 @@ void bta_hh_le_get_rpt(tBTA_HH_DEV_CB *p_cb, tBTA_HH_RPT_TYPE r_type, UINT8 rpt_ 
**

*******************************************************************************/

void bta_hh_le_write_rpt(tBTA_HH_DEV_CB *p_cb,

                         tBTA_GATTC_WRITE_TYPE   write_type,

                         tBTA_HH_RPT_TYPE r_type,

                         BT_HDR *p_buf, UINT16 w4_evt )

{
@@ -2316,6 +2315,13 @@ void bta_hh_le_write_rpt(tBTA_HH_DEV_CB *p_cb, 


    p_cb->w4_evt = w4_evt;



    const tBTA_GATTC_CHARACTERISTIC *p_char = BTA_GATTC_GetCharacteristic(p_cb->conn_id,

                                                                          p_rpt->char_inst_id);



    tBTA_GATTC_WRITE_TYPE write_type = BTA_GATTC_TYPE_WRITE;

    if (p_char && (p_char->properties & BTA_GATT_CHAR_PROP_BIT_WRITE_NR))

        write_type = BTA_GATTC_TYPE_WRITE_NO_RSP;



    gatt_queue_write_op(GATT_WRITE_CHAR, p_cb->conn_id, p_rpt->char_inst_id,

                        p_buf->len, p_value, write_type);

}
@@ -2367,7 +2373,6 @@ void bta_hh_le_write_dev_act(tBTA_HH_DEV_CB *p_cb, tBTA_HH_DATA *p_data) 


        case HID_TRANS_SET_REPORT:

            bta_hh_le_write_rpt(p_cb,

                                BTA_GATTC_TYPE_WRITE,

                                p_data->api_sndcmd.param,

                                p_data->api_sndcmd.p_data,

                                BTA_HH_SET_RPT_EVT);
@@ -2376,7 +2381,6 @@ void bta_hh_le_write_dev_act(tBTA_HH_DEV_CB *p_cb, tBTA_HH_DATA *p_data) 
        case HID_TRANS_DATA:  /* output report */



            bta_hh_le_write_rpt(p_cb,

                                BTA_GATTC_TYPE_WRITE_NO_RSP,

                                p_data->api_sndcmd.param,

                                p_data->api_sndcmd.p_data,

                                BTA_HH_DATA_EVT);