Merge changes I67e37c2d,I480c9a8e,I23891e4c,I9e65a141,Ica2cfe4e am: 66bca36b83 am: 442d57317e (776b3e67) · Commits · e / os / android_packages_modules_Bluetooth

tools/pdl/Android.bp

+6 −0

Original line number	Diff line number	Diff line
		@@ -47,6 +47,12 @@ rust_test_host {
		data: [
		":rustfmt",
		":rustfmt.toml",
		"tests/generated/generate_chunk_read_8bit.rs",
		"tests/generated/generate_chunk_read_16bit_be.rs",
		"tests/generated/generate_chunk_read_16bit_le.rs",
		"tests/generated/generate_chunk_read_24bit_be.rs",
		"tests/generated/generate_chunk_read_24bit_le.rs",
		"tests/generated/generate_chunk_read_multiple_fields.rs",
		"tests/generated/packet_decl_complex_big_endian.rs",
		"tests/generated/packet_decl_complex_little_endian.rs",
		"tests/generated/packet_decl_empty.rs",

tools/pdl/src/backends/rust.rs

+8 −14

Original line number	Diff line number	Diff line
		@@ -164,21 +164,17 @@ fn generate_packet_decl(
		panic!("packet {id} does not end on a byte boundary, size: {packet_size_bits} bits",);
		}
		let packet_size_bytes = syn::Index::from(packet_size_bits / 8);
		let get_size_adjustment = (packet_size_bytes.index > 0).then(\|\| {
		Some(quote! {
		let ret = ret + #packet_size_bytes;
		})
		});

		let conforms = if packet_size_bytes.index == 0 {
		quote! { true }
		} else {
		quote! { bytes.len() >= #packet_size_bytes }
		};

		code.push_str(&quote_block! {
		impl #data_name {
		fn conforms(bytes: &[u8]) -> bool {
		// TODO(mgeisler): return Boolean expression directly.
		// TODO(mgeisler): skip when total_field_size == 0.
		if bytes.len() < #packet_size_bytes {
		return false;
		}
		true
		#conforms
		}

		fn parse(bytes: &[u8]) -> Result<Self> {
		@@ -195,9 +191,7 @@ fn generate_packet_decl(
		}

		fn get_size(&self) -> usize {
		let ret = 0;
		#get_size_adjustment
		ret
		#packet_size_bytes
		}
		}
		});

tools/pdl/src/backends/rust/chunk.rs

+44 −121

Original line number	Diff line number	Diff line
		@@ -35,37 +35,22 @@ impl Chunk<'_> {
		}

		/// Generate length checks for this chunk.
		pub fn generate_length_checks(
		pub fn generate_length_check(
		&self,
		packet_name: &str,
		offset: usize,
		) -> Vec<proc_macro2::TokenStream> {
		let mut field_offset = offset;
		let mut last_field_range_end = 0;
		let mut length_checks = Vec::new();
		for field in self.fields {
		let id = field.get_id();
		let width = field.get_width();
		let field_range = get_field_range(field_offset, width);
		field_offset += width;
		if field_range.end == last_field_range_end {
		continue;
		}

		last_field_range_end = field_range.end;
		let range_end = syn::Index::from(field_range.end);
		length_checks.push(quote! {
		if bytes.len() < #range_end {
		) -> proc_macro2::TokenStream {
		let range = get_field_range(offset, self.get_width());
		let wanted_length = syn::Index::from(range.end);
		quote! {
		if bytes.len() < #wanted_length {
		return Err(Error::InvalidLengthError {
		obj: #packet_name.to_string(),
		field: #id.to_string(),
		wanted: #range_end,
		wanted: #wanted_length,
		got: bytes.len(),
		});
		}
		});
		}
		length_checks
		}

		/// Read data for a chunk.
		@@ -88,10 +73,7 @@ impl Chunk<'_> {

		let range = get_field_range(offset, chunk_width);
		let indices = range.map(syn::Index::from).collect::<Vec<_>>();

		// TODO(mgeisler): emit just a single length check per chunk. We
		// could even emit a single length check per packet.
		let length_checks = self.generate_length_checks(packet_name, offset);
		let length_check = self.generate_length_check(packet_name, offset);

		// When the chunk_type.width is larger than chunk_width (e.g.
		// chunk_width is 24 but chunk_type.width is 32), then we need
		@@ -112,7 +94,7 @@ impl Chunk<'_> {
		let read_adjustments = self.generate_read_adjustments();

		quote! {
		#(#length_checks)*
		#length_check
		let #chunk_name = #chunk_type::#getter([
		#(#zero_padding_before,)* #(bytes[#indices]),* #(, #zero_padding_after)*
		]);
		@@ -199,25 +181,17 @@ impl Chunk<'_> {
		mod tests {
		use super::*;
		use crate::backends::rust::field::ScalarField;
		use crate::test_utils::assert_expr_eq;
		use crate::test_utils::{assert_expr_eq, assert_snapshot_eq, rustfmt};

		#[test]
		fn test_generate_read_8bit() {
		let fields = [Field::Scalar(ScalarField { id: String::from("a"), width: 8 })];
		let chunk = Chunk::new(&fields);
		assert_expr_eq(
		chunk.generate_read("Foo", ast::EndiannessValue::BigEndian, 80),
		quote! {
		if bytes.len() < 11 {
		return Err(Error::InvalidLengthError {
		obj: "Foo".to_string(),
		field: "a".to_string(),
		wanted: 11,
		got: bytes.len(),
		});
		}
		let a = u8::from_be_bytes([bytes[10]]);
		},
		let chunk_read = chunk.generate_read("Foo", ast::EndiannessValue::BigEndian, 80);
		let code = quote! { fn main() { #chunk_read } };
		assert_snapshot_eq(
		"tests/generated/generate_chunk_read_8bit.rs",
		&rustfmt(&code.to_string()),
		);
		}

		@@ -225,19 +199,11 @@ mod tests {
		fn test_generate_read_16bit_le() {
		let fields = [Field::Scalar(ScalarField { id: String::from("a"), width: 16 })];
		let chunk = Chunk::new(&fields);
		assert_expr_eq(
		chunk.generate_read("Foo", ast::EndiannessValue::LittleEndian, 80),
		quote! {
		if bytes.len() < 12 {
		return Err(Error::InvalidLengthError {
		obj: "Foo".to_string(),
		field: "a".to_string(),
		wanted: 12,
		got: bytes.len(),
		});
		}
		let a = u16::from_le_bytes([bytes[10], bytes[11]]);
		},
		let chunk_read = chunk.generate_read("Foo", ast::EndiannessValue::LittleEndian, 80);
		let code = quote! { fn main() { #chunk_read } };
		assert_snapshot_eq(
		"tests/generated/generate_chunk_read_16bit_le.rs",
		&rustfmt(&code.to_string()),
		);
		}

		@@ -245,19 +211,11 @@ mod tests {
		fn test_generate_read_16bit_be() {
		let fields = [Field::Scalar(ScalarField { id: String::from("a"), width: 16 })];
		let chunk = Chunk::new(&fields);
		assert_expr_eq(
		chunk.generate_read("Foo", ast::EndiannessValue::BigEndian, 80),
		quote! {
		if bytes.len() < 12 {
		return Err(Error::InvalidLengthError {
		obj: "Foo".to_string(),
		field: "a".to_string(),
		wanted: 12,
		got: bytes.len(),
		});
		}
		let a = u16::from_be_bytes([bytes[10], bytes[11]]);
		},
		let chunk_read = chunk.generate_read("Foo", ast::EndiannessValue::BigEndian, 80);
		let code = quote! { fn main() { #chunk_read } };
		assert_snapshot_eq(
		"tests/generated/generate_chunk_read_16bit_be.rs",
		&rustfmt(&code.to_string()),
		);
		}

		@@ -265,19 +223,11 @@ mod tests {
		fn test_generate_read_24bit_le() {
		let fields = [Field::Scalar(ScalarField { id: String::from("a"), width: 24 })];
		let chunk = Chunk::new(&fields);
		assert_expr_eq(
		chunk.generate_read("Foo", ast::EndiannessValue::LittleEndian, 80),
		quote! {
		if bytes.len() < 13 {
		return Err(Error::InvalidLengthError {
		obj: "Foo".to_string(),
		field: "a".to_string(),
		wanted: 13,
		got: bytes.len(),
		});
		}
		let a = u32::from_le_bytes([bytes[10], bytes[11], bytes[12], 0]);
		},
		let chunk_read = chunk.generate_read("Foo", ast::EndiannessValue::LittleEndian, 80);
		let code = quote! { fn main() { #chunk_read } };
		assert_snapshot_eq(
		"tests/generated/generate_chunk_read_24bit_le.rs",
		&rustfmt(&code.to_string()),
		);
		}

		@@ -285,19 +235,11 @@ mod tests {
		fn test_generate_read_24bit_be() {
		let fields = [Field::Scalar(ScalarField { id: String::from("a"), width: 24 })];
		let chunk = Chunk::new(&fields);
		assert_expr_eq(
		chunk.generate_read("Foo", ast::EndiannessValue::BigEndian, 80),
		quote! {
		if bytes.len() < 13 {
		return Err(Error::InvalidLengthError {
		obj: "Foo".to_string(),
		field: "a".to_string(),
		wanted: 13,
		got: bytes.len(),
		});
		}
		let a = u32::from_be_bytes([0, bytes[10], bytes[11], bytes[12]]);
		},
		let chunk_read = chunk.generate_read("Foo", ast::EndiannessValue::BigEndian, 80);
		let code = quote! { fn main() { #chunk_read } };
		assert_snapshot_eq(
		"tests/generated/generate_chunk_read_24bit_be.rs",
		&rustfmt(&code.to_string()),
		);
		}

		@@ -308,30 +250,11 @@ mod tests {
		Field::Scalar(ScalarField { id: String::from("b"), width: 24 }),
		];
		let chunk = Chunk::new(&fields);
		assert_expr_eq(
		chunk.generate_read("Foo", ast::EndiannessValue::BigEndian, 80),
		quote! {
		if bytes.len() < 12 {
		return Err(Error::InvalidLengthError {
		obj: "Foo".to_string(),
		field: "a".to_string(),
		wanted: 12,
		got: bytes.len(),
		});
		}
		if bytes.len() < 15 {
		return Err(Error::InvalidLengthError {
		obj: "Foo".to_string(),
		field: "b".to_string(),
		wanted: 15,
		got: bytes.len(),
		});
		}
		let chunk =
		u64::from_be_bytes([0, 0, 0, bytes[10], bytes[11], bytes[12], bytes[13], bytes[14]]);
		let a = chunk as u16;
		let b = ((chunk >> 16) & 0xffffff) as u32;
		},
		let chunk_read = chunk.generate_read("Foo", ast::EndiannessValue::BigEndian, 80);
		let code = quote! { fn main() { #chunk_read } };
		assert_snapshot_eq(
		"tests/generated/generate_chunk_read_multiple_fields.rs",
		&rustfmt(&code.to_string()),
		);
		}

tools/pdl/src/backends/rust/field.rs

+0 −10

Original line number	Diff line number	Diff line
		@@ -20,10 +20,6 @@ impl ScalarField {
		self.width
		}

		fn get_id(&self) -> &str {
		&self.id
		}

		fn get_ident(&self) -> proc_macro2::Ident {
		format_ident!("{}", self.id)
		}
		@@ -149,12 +145,6 @@ impl Field {
		}
		}

		pub fn get_id(&self) -> &str {
		match self {
		Field::Scalar(field) => field.get_id(),
		}
		}

		pub fn get_ident(&self) -> proc_macro2::Ident {
		match self {
		Field::Scalar(field) => field.get_ident(),

tools/pdl/src/backends/rust/preamble.rs

+2 −2

Original line number	Diff line number	Diff line
		@@ -29,8 +29,8 @@ pub fn generate(path: &Path) -> String {
		InvalidPacketError,
		#[error("{field} was {value:x}, which is not known")]
		ConstraintOutOfBounds { field: String, value: u64 },
		#[error("when parsing {obj}.{field} needed length of {wanted} but got {got}")]
		InvalidLengthError { obj: String, field: String, wanted: usize, got: usize },
		#[error("when parsing {obj} needed length of {wanted} but got {got}")]
		InvalidLengthError { obj: String, wanted: usize, got: usize },
		#[error("Due to size restrictions a struct could not be parsed.")]
		ImpossibleStructError,
		#[error("when parsing field {obj}.{field}, {value} is not a valid {type_} value")]