Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7401e8f8 authored by Qasim Javed's avatar Qasim Javed
Browse files

rusty-gd: Use entire slice during packet parsing 

The field offsets for the child packets are relative to the parent
packet so we do not need to use specify a starting offset when calling
the child packet's parse method.

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost

Change-Id: I472f3365259c653143a973c4412d685c20f62808
parent 52c299b2

system/gd/packet/parser/packet_def.cc

+2 −2
Original line number Diff line number Diff line
@@ -945,10 +945,10 @@ void PacketDef::GenRustStructImpls(std::ostream& s) const { 
        s << name_ << "DataChild::";

        s << desc_path[0]->name_ << "(Arc::new(";

        if (desc_path[0]->parent_constraints_.empty()) {

          s << desc_path[0]->name_ << "Data::parse(&bytes[" << payload_offset.bytes() << "..]";

          s << desc_path[0]->name_ << "Data::parse(&bytes[..]";

          s << ", " << enum_variant << ")?))";

        } else {

          s << desc_path[0]->name_ << "Data::parse(&bytes[" << payload_offset.bytes() << "..])?))";

          s << desc_path[0]->name_ << "Data::parse(&bytes[..])?))";

        }

      } else if (constraint_type == ScalarField::kFieldType) {

        s << std::get<int64_t>(desc.second) << " => {";