Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 718203ec authored by Chris Manton's avatar Chris Manton
Browse files

gd: Prevent erroneous fail connection on acceptlist change 

The packet fields are invalid for the conditioned logic.

Bug: 187736009
Test: gd/cert/run
Tag: #refactor

Change-Id: Ie4e4dcf1333c4f5f3a10635f6ed91380cb873f73
parent d808c540

system/gd/hci/acl_manager/le_impl.h

+2 −4
Original line number Diff line number Diff line
@@ -151,8 +151,7 @@ struct le_impl : public bluetooth::hci::LeAddressManagerCallback { 
    AddressWithType remote_address(address, peer_address_type);

    AddressWithType local_address = le_address_manager_->GetCurrentAddress();

    on_common_le_connection_complete(remote_address);

    if (status == ErrorCode::UNKNOWN_CONNECTION &&

        canceled_connections_.find(remote_address) != canceled_connections_.end()) {

    if (status == ErrorCode::UNKNOWN_CONNECTION && pause_connection) {

      // connection canceled by LeAddressManager.OnPause(), will auto reconnect by LeAddressManager.OnResume()

      return;

    } else {
@@ -210,8 +209,7 @@ struct le_impl : public bluetooth::hci::LeAddressManagerCallback { 
      remote_address = AddressWithType(peer_resolvable_address, AddressType::RANDOM_DEVICE_ADDRESS);

    }

    on_common_le_connection_complete(remote_address);

    if (status == ErrorCode::UNKNOWN_CONNECTION &&

        canceled_connections_.find(remote_address) != canceled_connections_.end()) {

    if (status == ErrorCode::UNKNOWN_CONNECTION && pause_connection) {

      // connection canceled by LeAddressManager.OnPause(), will auto reconnect by LeAddressManager.OnResume()

      return;

    } else {