Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 69611e28 authored by William Escande's avatar William Escande
Browse files

ErrorProne: Enforce & fix NotJavadoc 

See https://errorprone.info/bugpattern/NotJavadoc

Bug: 344658662
Test: m BluetoothInstrumentationTests
Flag: Exempt Build and test only
Change-Id: Ia9f98f67cac6ce7fb75204a869fed82a2e492bae
parent d7e497e0

android/app/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -331,6 +331,7 @@ android_app { 
            "-Xep:MockNotUsedInProduction:ERROR",

            "-Xep:NonApiType:ERROR",

            "-Xep:NonCanonicalType:ERROR",

            "-Xep:NotJavadoc:ERROR",

            "-Xep:ReturnAtTheEndOfVoidFunction:ERROR",

            "-Xep:StringCaseLocaleUsage:ERROR",

            "-Xep:StringCharset:ERROR",

android/app/src/com/android/bluetooth/audio_util/MediaPlayerList.java

+2 −8
Original line number Diff line number Diff line
@@ -377,7 +377,7 @@ public class MediaPlayerList { 
                sendFolderUpdate(false, true, false);

            }

        } else {

            /** M: Fix PTS AVRCP/TG/MCN/CB/BI-02-C fail @{ */

            // Fix PTS AVRCP/TG/MCN/CB/BI-02-C

            if (Utils.isPtsTestMode()) {

                d("PTS test mode: getPlayerRoot");

                BrowsedPlayerWrapper wrapper = mBrowsablePlayers.get(BLUETOOTH_PLAYER_ID + 1);
@@ -394,9 +394,6 @@ public class MediaPlayerList { 
                        });

                return;

            }

            /**

             * @}

             */

            cb.run(playerId, playerId == BLUETOOTH_PLAYER_ID, "", mBrowsablePlayers.size());

        }

    }
@@ -661,7 +658,7 @@ public class MediaPlayerList { 
        Log.d(TAG, "getFolderItems(): playerId=" + playerId + ", mediaId=" + mediaId);



        if (!Flags.browsingRefactor() && Utils.isPtsTestMode()) {

            /** M: Fix PTS AVRCP/TG/MCN/CB/BI-02-C fail @{ */

            // Fix PTS AVRCP/TG/MCN/CB/BI-02-C

            d("PTS test mode: getFolderItems");

            BrowsedPlayerWrapper wrapper = mBrowsablePlayers.get(BLUETOOTH_PLAYER_ID + 1);

            String itemId = mediaId;
@@ -679,9 +676,6 @@ public class MediaPlayerList { 
                        cb.run(mediaId, results);

                    });

            return;

            /**

             * @}

             */

        }



        // The device is requesting the content of the root folder. This folder contains a list of

android/app/src/com/android/bluetooth/hfp/HeadsetService.java

+1 −1
Original line number Diff line number Diff line
@@ -2055,7 +2055,7 @@ public class HeadsetService extends ProfileService { 
                if (currentPolicy != null

                        && currentPolicy.getActiveDevicePolicyAfterConnection()

                                == BluetoothSinkAudioPolicy.POLICY_NOT_ALLOWED) {

                    /**

                    /*

                     * If the active device was set because of the pick up audio policy and the

                     * connecting policy is NOT_ALLOWED, then after the call is terminated, we must

                     * de-activate this device. If there is a fallback mechanism, we should follow

android/app/src/com/android/bluetooth/map/BluetoothMapContentObserver.java

+1 −1
Original line number Diff line number Diff line
@@ -3453,7 +3453,7 @@ public class BluetoothMapContentObserver { 
    }



    private long pushMmsToFolder(int folder, String[] toAddress, BluetoothMapbMessageMime msg) {

        /**

        /*

         * strategy: 1) parse msg into parts + header 2) create thread id (abuse the ease of adding

         * an SMS to get id for thread) 3) push parts into content://mms/parts/ table 3)

         */

android/app/src/com/android/bluetooth/map/BluetoothMapSmsPdu.java

+1 −1
Original line number Diff line number Diff line
@@ -826,7 +826,7 @@ public class BluetoothMapSmsPdu { 


    private static int[] getTableFromByteArray(byte[] data) {

        ByteArrayInputStream inStream = new ByteArrayInputStream(data);

        /** tableValue[0]: languageTable tableValue[1]: languageShiftTable */

        /* tableValue[0]: languageTable tableValue[1]: languageShiftTable */

        int[] tableValue = new int[2];

        while (inStream.available() > 0) {

            int id = inStream.read();