Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 693806af authored by Henri Chataing's avatar Henri Chataing
Browse files

system/btif: clang-tidy fixes 

Bug: 374984156
Test: m com.android.btservices
Test: WITH_TIDY_FLAGS=--fix m libbtif
Flag: EXEMPT, no logical change
Change-Id: I1f89824743dd57ca6961c513e460603623d1f117
parent 36f11beb

.clang-tidy

+16 −2
Original line number Diff line number Diff line 
---

CheckOptions:

  - key: misc-include-cleaner.IgnoreHeaders

    value:           (fmt/.*|bits/pthread_types\.h)
 
    value: "(\

        fmt/.*|\

        bits/.*.h|\

        asm-generic/.*.h|\

        sys/poll.h|\

        sys/endian.h|\

        sys/ioctl.h|\

        arpa/inet.h|\

        linux/if.h|\

        linux/sockios.h|\

        netinet/in.h|\

        osi/include/compat.h|\

        android_bluetooth_sysprop.h|\

        hfp.sysprop.h|\

        __chrono/duration.h)"

Android.bp

+5 −0
Original line number Diff line number Diff line
@@ -85,6 +85,11 @@ bluetooth_tidy_checks = [ 
    // This check implements detection of local variables which could be declared

    // as const but are not.

    "-misc-const-correctness",



    // Finds classes that contain non-static data members in addition to user-declared

    // non-static member functions and diagnose all data members declared with a

    // non-public access specifier.

    "-misc-non-private-member-variables-in-classes",

]



// This default tidy checks that will be run against all the cc targets

OWNERS

+1 −1
Original line number Diff line number Diff line
@@ -9,7 +9,7 @@ okamil@google.com #{LAST_RESORT_SUGGESTION} 
# Per-file ownership



# Build files / test_config / presubmit / preupload / linter file

per-file PREUPLOAD.cfg,TEST_MAPPING,*.bp,*.xml,pyrightconfig.json=file:/OWNERS_build

per-file PREUPLOAD.cfg,TEST_MAPPING,*.bp,*.xml,.clang-tidy,pyrightconfig.json=file:/OWNERS_build



# ChromeOS team owns Linux build files

# - build.py is used for Linux build

system/btif/avrcp/avrcp_service.cc

+17 −0
Original line number Diff line number Diff line
@@ -21,8 +21,13 @@ 
#include <base/threading/thread.h>

#include <bluetooth/log.h>

#include <com_android_bluetooth_flags.h>

#include <stdio.h>



#include <cstddef>

#include <cstdint>

#include <memory>

#include <mutex>

#include <ostream>

#include <sstream>

#include <string>

#include <utility>
@@ -31,14 +36,26 @@ 
#include "bta/sys/bta_sys.h"

#include "btif/include/btif_av.h"

#include "btif/include/btif_common.h"

#include "hardware/avrcp/avrcp.h"

#include "hardware/avrcp/avrcp_common.h"

#include "internal_include/bt_target.h"

#include "osi/include/osi.h"

#include "profile/avrcp/avrcp_config.h"

#include "profile/avrcp/avrcp_internal.h"

#include "profile/avrcp/avrcp_sdp_records.h"

#include "profile/avrcp/avrcp_sdp_service.h"

#include "profile/avrcp/device.h"

#include "stack/include/a2dp_api.h"

#include "stack/include/avct_api.h"

#include "stack/include/avrc_api.h"

#include "stack/include/avrc_defs.h"

#include "stack/include/bt_hdr.h"

#include "stack/include/bt_uuid16.h"

#include "stack/include/main_thread.h"

#include "stack/include/sdp_api.h"

#include "stack/include/sdp_callback.h"

#include "stack/include/sdpdefs.h"

#include "stack/sdp/sdp_discovery_db.h"

#include "types/bluetooth/uuid.h"

#include "types/raw_address.h"

system/btif/co/bta_av_co.cc

+6 −2
Original line number Diff line number Diff line
@@ -29,7 +29,11 @@ 


#include <bluetooth/log.h>

#include <com_android_bluetooth_flags.h>

#include <stdio.h>



#include <cstddef>

#include <cstdint>

#include <cstring>

#include <mutex>

#include <optional>

#include <vector>
@@ -42,16 +46,16 @@ 
#include "btif/include/btif_a2dp_source.h"

#include "btif/include/btif_av.h"

#include "btif/include/btif_av_co.h"

#include "device/include/device_iot_conf_defs.h"

#include "device/include/device_iot_config.h"

#include "include/hardware/bt_av.h"

#include "internal_include/bt_trace.h"

#include "os/logging/log_adapter.h"

#include "osi/include/allocator.h"

#include "stack/include/a2dp_codec_api.h"

#include "stack/include/a2dp_constants.h"

#include "stack/include/a2dp_ext.h"

#include "stack/include/avdt_api.h"

#include "stack/include/bt_hdr.h"

#include "stack/include/bt_types.h"

#include "stack/include/bt_uuid16.h"

#include "types/raw_address.h"