Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6806ca1d authored by William Escande's avatar William Escande
Browse files

Enforce lint RtlHardcoded and fix usages 

Bug: 289445022
Test: m Bluetooth
Change-Id: I4867aab1cfe8f4587faf4dde635c0b423e8850fb
parent 92f40563

android/app/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -262,6 +262,7 @@ android_app { 
            "NewApi",

            "ObsoleteSdkInt",

            "Recycle",

            "RtlHardcoded",

            "UseSparseArrays",

            "UseValueOf",

        ],

android/app/lint-baseline.xml

+0 −184
Original line number Diff line number Diff line
@@ -7151,188 +7151,4 @@ 
            line="61"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_alignParentLeft` with `android:layout_alignParentStart=&quot;true&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/bluetooth_map_settings_account_group.xml"

            line="27"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_marginLeft` with `android:layout_marginStart=&quot;30dp&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/bluetooth_map_settings_account_group.xml"

            line="31"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_toRightOf` with `android:layout_toEndOf=&quot;@id/bluetooth_map_settings_group_icon&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/bluetooth_map_settings_account_group.xml"

            line="37"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_alignParentRight` with `android:layout_alignParentEnd=&quot;true&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/bluetooth_map_settings_account_group.xml"

            line="42"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:paddingLeft` with `android:paddingStart=&quot;51dp&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/bluetooth_map_settings_account_item.xml"

            line="25"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:paddingRight` with `android:paddingEnd=&quot;25dp&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/bluetooth_map_settings_account_item.xml"

            line="26"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Use &quot;`start`&quot; instead of &quot;`left`&quot; to ensure correct behavior in right-to-left locales">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/bluetooth_map_settings_account_item.xml"

            line="34"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Use &quot;`end`&quot; instead of &quot;`right`&quot; to ensure correct behavior in right-to-left locales">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/bluetooth_map_settings_account_item.xml"

            line="40"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Use &quot;`end`&quot; instead of &quot;`right`&quot; to ensure correct behavior in right-to-left locales">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/bluetooth_map_settings_account_item.xml"

            line="42"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_marginLeft` with `android:layout_marginStart=&quot;20dip&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/file_transfer.xml"

            line="86"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Use &quot;`start`&quot; instead of &quot;`left`&quot; to ensure correct behavior in right-to-left locales">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/file_transfer.xml"

            line="88"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_marginLeft` with `android:layout_marginStart=&quot;10dip&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/file_transfer.xml"

            line="93"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_marginRight` with `android:layout_marginEnd=&quot;20dip&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/file_transfer.xml"

            line="94"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Use &quot;`start`&quot; instead of &quot;`left`&quot; to ensure correct behavior in right-to-left locales">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/testactivity_main.xml"

            line="9"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_marginRight` with `android:layout_marginEnd=&quot;3dip&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/testactivity_main.xml"

            line="12"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Use &quot;`start`&quot; instead of &quot;`left`&quot; to ensure correct behavior in right-to-left locales">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/testactivity_main.xml"

            line="23"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_marginRight` with `android:layout_marginEnd=&quot;3dip&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/testactivity_main.xml"

            line="36"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_marginRight` with `android:layout_marginEnd=&quot;3dip&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/testactivity_main.xml"

            line="45"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_marginRight` with `android:layout_marginEnd=&quot;3dip&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/testactivity_main.xml"

            line="54"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_marginRight` with `android:layout_marginEnd=&quot;3dip&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/testactivity_main.xml"

            line="63"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_marginRight` with `android:layout_marginEnd=&quot;3dip&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/testactivity_main.xml"

            line="72"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_marginRight` with `android:layout_marginEnd=&quot;3dip&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/testactivity_main.xml"

            line="81"/>

    </issue>



    <issue

        id="RtlHardcoded"

        message="Consider replacing `android:layout_marginRight` with `android:layout_marginEnd=&quot;3dip&quot;` to better support right-to-left layouts">

        <location

            file="packages/modules/Bluetooth/android/app/res/layout/testactivity_main.xml"

            line="90"/>

    </issue>



</issues>

android/app/res/layout/bluetooth_map_settings_account_group.xml

+4 −4
Original line number Diff line number Diff line
@@ -24,22 +24,22 @@ 
        android:id="@+id/bluetooth_map_settings_group_icon"

        android:layout_width="64dp"

        android:layout_height="64dp"

        android:layout_alignParentLeft="true"

        android:layout_alignParentStart="true"

        android:layout_alignParentTop="true"

        android:maxWidth="64dp"

        android:maxHeight="64dp"

        android:layout_marginLeft="30dp"

        android:layout_marginStart="30dp"

         />

    <TextView

        android:id ="@+id/bluetooth_map_settings_group_text_view"

        android:layout_width ="wrap_content"

        android:layout_height ="wrap_content"

        android:layout_toRightOf="@id/bluetooth_map_settings_group_icon"/>

        android:layout_toEndOf="@id/bluetooth_map_settings_group_icon"/>

    <CheckBox

        android:id ="@+id/bluetooth_map_settings_group_checkbox"

        android:layout_width ="wrap_content"

        android:layout_height="wrap_content"

        android:layout_alignParentRight="true"

        android:layout_alignParentEnd="true"

        android:layout_centerVertical="true"

        android:focusable="false"/>

android/app/res/layout/bluetooth_map_settings_account_item.xml

+5 −5
Original line number Diff line number Diff line
@@ -22,8 +22,8 @@ 
    android:clickable="true"

    android:gravity="fill_vertical"

    android:orientation="horizontal"

    android:paddingLeft="51dp"

    android:paddingRight="25dp"

    android:paddingEnd="51dp"

    android:paddingStart="25dp"

    tools:context=".BluetoothMapSettings" android:baselineAligned="false">



        <TextView
@@ -31,13 +31,13 @@ 
            android:layout_width="match_parent"

            android:layout_height="51dp"

            android:layout_weight="1"

            android:gravity="left|center_vertical"/>

            android:gravity="start|center_vertical"/>



        <CheckBox

            android:id="@+id/bluetooth_map_settings_item_check"

            android:layout_width="110dp"

            android:layout_height="51dp"

            android:layout_gravity="right"

            android:layout_gravity="end"

            android:layout_weight="2"

            android:gravity="right|center_vertical" />

            android:gravity="end|center_vertical" />

</LinearLayout>

android/app/res/layout/file_transfer.xml

+4 −4
Original line number Diff line number Diff line
@@ -83,15 +83,15 @@ 
                android:id="@+id/progress_percent"

                android:layout_height="wrap_content"

                android:layout_width="wrap_content"

                android:layout_marginLeft="20dip"

                android:layout_marginEnd="20dip"

                android:textAppearance="?android:attr/textAppearanceSmall"

                android:gravity="left" />

                android:gravity="start" />



            <ProgressBar android:id="@+id/progress_transfer"

                style="?android:attr/progressBarStyleHorizontal"

                android:layout_height="wrap_content"

                android:layout_marginLeft="10dip"

                android:layout_marginRight="20dip"

                android:layout_marginEnd="10dip"

                android:layout_marginStart="20dip"

                android:layout_width="0dip"

                android:layout_weight="1"

                android:max="100"