Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 649e521c authored by Hsin-chen Chuang's avatar Hsin-chen Chuang
Browse files

floss: Re-enable ReadFailedContactCounter 

The issue has been fixed in FW, thus removing this

Bug: 249876976
Tag: #floss
Test: mmm packages/modules/Bluetooth
Test: Play audio on Brya (AX211), move the headset far to trigger buffer
      overflow, Floss doesn't crash
Flag: EXEMPT, Floss-only change
Change-Id: I955d55d49e48a757ca7d002ff74947acef13048c
parent 09129bd4

system/btif/src/btif_a2dp_source.cc

+0 −8
Original line number Diff line number Diff line
@@ -1013,18 +1013,10 @@ static bool btif_a2dp_source_enqueue_callback(BT_HDR* p_buf, size_t frames_n, 
      log::warn("Cannot read RSSI: status {}", status);

    }



    // Intel controllers don't handle ReadFailedContactCounter very well, it

    // sends back Hardware Error event which will crash the daemon. So

    // temporarily disable this for Floss.

    // TODO(b/249876976): Intel controllers to handle this command correctly.

    // And if the need for disabling metrics-related HCI call grows, consider

    // creating a framework to avoid ifdefs.

#ifndef TARGET_FLOSS

    status = BTM_ReadFailedContactCounter(peer_bda, btm_read_failed_contact_counter_cb);

    if (status != tBTM_STATUS::BTM_CMD_STARTED) {

      log::warn("Cannot read Failed Contact Counter: status {}", status);

    }

#endif



    status = BTM_ReadTxPower(peer_bda, BT_TRANSPORT_BR_EDR, btm_read_tx_power_cb);

    if (status != tBTM_STATUS::BTM_CMD_STARTED) {