Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 639be0e0 authored by William Escande's avatar William Escande
Browse files

LeAudio: Make sure test does not call native 

Bug: 295237486
Test: atest LeAudioBroadcastServiceTest
Change-Id: Ib5ab871b8a928993f377218aebbb4f9c11bbb108
parent 2112a3d3

android/app/src/com/android/bluetooth/le_audio/LeAudioBroadcasterNativeInterface.java

+14 −1
Original line number Diff line number Diff line
@@ -41,11 +41,16 @@ public class LeAudioBroadcasterNativeInterface { 


    @GuardedBy("INSTANCE_LOCK")

    private static LeAudioBroadcasterNativeInterface sInstance;



    private static final Object INSTANCE_LOCK = new Object();



    static {

        if (Utils.isInstrumentationTestMode()) {

            Log.w(TAG, "App is instrumented. Skip loading the native");

        } else {

            classInitNative();

        }

    }



    private LeAudioBroadcasterNativeInterface() {

        mAdapter = BluetoothAdapter.getDefaultAdapter();
@@ -66,6 +71,14 @@ public class LeAudioBroadcasterNativeInterface { 
        }

    }



    /** Set singleton instance. */

    @VisibleForTesting

    static void setInstance(LeAudioBroadcasterNativeInterface instance) {

        synchronized (INSTANCE_LOCK) {

            sInstance = instance;

        }

    }



    private void sendMessageToService(LeAudioStackEvent event) {

        LeAudioService service = LeAudioService.getLeAudioService();

        if (service != null) {

android/app/src/com/android/bluetooth/le_audio/LeAudioNativeInterface.java

+7 −2
Original line number Diff line number Diff line
@@ -37,17 +37,22 @@ import java.util.Arrays; 
 * LeAudio Native Interface to/from JNI.

 */

public class LeAudioNativeInterface {

    private static final String TAG = "LeAudioNativeInterface";

    private static final String TAG = LeAudioNativeInterface.class.getSimpleName();

    private static final boolean DBG = true;

    private BluetoothAdapter mAdapter;



    @GuardedBy("INSTANCE_LOCK")

    private static LeAudioNativeInterface sInstance;



    private static final Object INSTANCE_LOCK = new Object();



    static {

        if (Utils.isInstrumentationTestMode()) {

            Log.w(TAG, "App is instrumented. Skip loading the native");

        } else {

            classInitNative();

        }

    }



    private LeAudioNativeInterface() {

        mAdapter = BluetoothAdapter.getDefaultAdapter();

android/app/tests/unit/src/com/android/bluetooth/le_audio/LeAudioBroadcastServiceTest.java

+27 −18
Original line number Diff line number Diff line
@@ -28,7 +28,6 @@ import android.content.IntentFilter; 
import android.media.AudioManager;

import android.os.Looper;



import android.os.ParcelUuid;

import androidx.test.InstrumentationRegistry;

import androidx.test.filters.MediumTest;

import androidx.test.rule.ServiceTestRule;
@@ -70,8 +69,8 @@ public class LeAudioBroadcastServiceTest { 
    private DatabaseManager mDatabaseManager;

    @Mock

    private AudioManager mAudioManager;

    @Mock

    private LeAudioBroadcasterNativeInterface mNativeInterface;

    @Mock private LeAudioBroadcasterNativeInterface mLeAudioBroadcasterNativeInterface;

    @Mock private LeAudioNativeInterface mLeAudioNativeInterface;

    @Mock private LeAudioTmapGattServer mTmapGattServer;

    @Spy private LeAudioObjectsFactory mObjectsFactory = LeAudioObjectsFactory.getInstance();
@@ -179,9 +178,10 @@ public class LeAudioBroadcastServiceTest { 


        mAdapter = BluetoothAdapter.getDefaultAdapter();



        LeAudioBroadcasterNativeInterface.setInstance(mLeAudioBroadcasterNativeInterface);

        LeAudioNativeInterface.setInstance(mLeAudioNativeInterface);

        startService();

        mService.mAudioManager = mAudioManager;

        mService.mLeAudioBroadcasterNativeInterface = mNativeInterface;



        // Set up the State Changed receiver

        IntentFilter filter = new IntentFilter();
@@ -191,7 +191,7 @@ public class LeAudioBroadcastServiceTest { 
        mTargetContext.registerReceiver(mLeAudioIntentReceiver, filter);



        mDevice = TestUtils.getTestDevice(mAdapter, 0);

        when(mNativeInterface.getDevice(any(byte[].class))).thenReturn(mDevice);

        when(mLeAudioBroadcasterNativeInterface.getDevice(any(byte[].class))).thenReturn(mDevice);



        mIntentQueue = new LinkedBlockingQueue<Intent>();

    }
@@ -203,6 +203,8 @@ public class LeAudioBroadcastServiceTest { 
        }



        stopService();

        LeAudioBroadcasterNativeInterface.setInstance(null);

        LeAudioNativeInterface.setInstance(null);

        mTargetContext.unregisterReceiver(mLeAudioIntentReceiver);

        TestUtils.clearAdapterService(mAdapterService);

        reset(mAudioManager);
@@ -258,7 +260,10 @@ public class LeAudioBroadcastServiceTest { 
                        .map(setting -> setting.getContentMetadata().getRawMetadata())

                        .toArray(byte[][]::new);



        verify(mNativeInterface, times(1)).createBroadcast(eq(true), eq(TEST_BROADCAST_NAME),

        verify(mLeAudioBroadcasterNativeInterface, times(1))

                .createBroadcast(

                        eq(true),

                        eq(TEST_BROADCAST_NAME),

                        eq(settings.getBroadcastCode()),

                        eq(settings.getPublicBroadcastMetadata().getRawMetadata()),

                        eq(expectedQualityArray),
@@ -272,7 +277,7 @@ public class LeAudioBroadcastServiceTest { 
        mService.messageFromNative(create_event);



        // Verify if broadcast is auto-started on start

        verify(mNativeInterface, times(1)).startBroadcast(eq(broadcastId));

        verify(mLeAudioBroadcasterNativeInterface, times(1)).startBroadcast(eq(broadcastId));



        // Notify initial paused state

        LeAudioStackEvent state_event =
@@ -288,14 +293,14 @@ public class LeAudioBroadcastServiceTest { 
        mService.messageFromNative(state_event);



        // Check if metadata is requested when the broadcast starts to stream

        verify(mNativeInterface, times(1)).getBroadcastMetadata(eq(broadcastId));

        verify(mLeAudioBroadcasterNativeInterface, times(1)).getBroadcastMetadata(eq(broadcastId));

        Assert.assertFalse(mOnBroadcastStartFailedCalled);

        Assert.assertTrue(mOnBroadcastStartedCalled);

    }



    void verifyBroadcastStopped(int broadcastId) {

        mService.stopBroadcast(broadcastId);

        verify(mNativeInterface, times(1)).stopBroadcast(eq(broadcastId));

        verify(mLeAudioBroadcasterNativeInterface, times(1)).stopBroadcast(eq(broadcastId));



        LeAudioStackEvent state_event =

                new LeAudioStackEvent(LeAudioStackEvent.EVENT_TYPE_BROADCAST_STATE);
@@ -304,7 +309,7 @@ public class LeAudioBroadcastServiceTest { 
        mService.messageFromNative(state_event);



        // Verify if broadcast is auto-destroyed on stop

        verify(mNativeInterface, times(1)).destroyBroadcast(eq(broadcastId));

        verify(mLeAudioBroadcasterNativeInterface, times(1)).destroyBroadcast(eq(broadcastId));



        state_event = new LeAudioStackEvent(LeAudioStackEvent.EVENT_TYPE_BROADCAST_DESTROYED);

        state_event.valueInt1 = broadcastId;
@@ -367,8 +372,12 @@ public class LeAudioBroadcastServiceTest { 
        byte[][] expectedDataArray =

                {settings.getSubgroupSettings().get(0).getContentMetadata().getRawMetadata()};



        verify(mNativeInterface, times(1)).createBroadcast(eq(true), eq(TEST_BROADCAST_NAME),

                eq(code), eq(settings.getPublicBroadcastMetadata().getRawMetadata()),

        verify(mLeAudioBroadcasterNativeInterface, times(1))

                .createBroadcast(

                        eq(true),

                        eq(TEST_BROADCAST_NAME),

                        eq(code),

                        eq(settings.getPublicBroadcastMetadata().getRawMetadata()),

                        eq(expectedQualityArray),

                        eq(expectedDataArray));