Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6313ed4b authored by Jeff Vander Stoep's avatar Jeff Vander Stoep Committed by William Escande
Browse files

Replace use of deprecated function with_min_level 

This is needed to upgrade the android_logger crate from 0.12.0
to 0.13.3.

with_max_level provides the same functionality as with_min_level.
The renaming is admittedly confusing, but the new name is accurate
and it makes sense that they deprecated and then removed the
previously poorly named with_min_level.

See crate documentation [1] and code [2].

[1]: https://docs.rs/android_logger/0.12.0/android_logger/struct.Config.html#method.with_min_level
[2]: https://docs.rs/android_logger/0.12.0/src/android_logger/lib.rs.html#227

Bug: 322718401
Test: build and run CF with the change.
Test: m aosp_cf_x86_64_phone
Flag: Exempt, Rust Floss change
Change-Id: I95efbdcff16451938c20407ae2abe11b949472b3
parent 55bb2ee5

system/gd/rust/common/src/logging.rs

+13 −17
Original line number Diff line number Diff line
@@ -3,16 +3,16 @@ use crate::init_flags::{ 
    LOG_TAG_NOTICE, LOG_TAG_VERBOSE, LOG_TAG_WARN,

};



fn get_log_level() -> log::Level {

fn get_log_level() -> log::LevelFilter {

    match get_log_level_for_tag("bluetooth_core") {

        LOG_TAG_FATAL => log::Level::Error,

        LOG_TAG_ERROR => log::Level::Error,

        LOG_TAG_WARN => log::Level::Warn,

        LOG_TAG_NOTICE => log::Level::Info,

        LOG_TAG_INFO => log::Level::Info,

        LOG_TAG_DEBUG => log::Level::Debug,

        LOG_TAG_VERBOSE => log::Level::Trace,

        _ => log::Level::Info, // default level

        LOG_TAG_FATAL => log::LevelFilter::Error,

        LOG_TAG_ERROR => log::LevelFilter::Error,

        LOG_TAG_WARN => log::LevelFilter::Warn,

        LOG_TAG_NOTICE => log::LevelFilter::Info,

        LOG_TAG_INFO => log::LevelFilter::Info,

        LOG_TAG_DEBUG => log::LevelFilter::Debug,

        LOG_TAG_VERBOSE => log::LevelFilter::Trace,

        _ => log::LevelFilter::Info, // default level

    }

}
@@ -20,18 +20,14 @@ fn get_log_level() -> log::Level { 
#[cfg(target_os = "android")]

pub fn init_logging() {

    android_logger::init_once(

        android_logger::Config::default().with_tag("bt").with_min_level(get_log_level()),

        android_logger::Config::default().with_tag("bt").with_max_level(get_log_level()),

    );

    log::set_max_level(get_log_level().to_level_filter())

    log::set_max_level(get_log_level())

}



/// Inits logging for host

#[cfg(not(target_os = "android"))]

pub fn init_logging() {

    env_logger::Builder::new()

        .filter(None, get_log_level().to_level_filter())

        .parse_default_env()

        .try_init()

        .ok();

    log::set_max_level(get_log_level().to_level_filter())

    env_logger::Builder::new().filter(None, get_log_level()).parse_default_env().try_init().ok();

    log::set_max_level(get_log_level())

}