Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5989f8b0 authored by Archie Pusaka's avatar Archie Pusaka
Browse files

Floss: Hcidoc: Attempt to identify Nocp for unknown handle 

Currently when a device is disconnected and the handle is unknown
(happens when the connect complete event occurs before the start of
the snoop log), we don't report the potential Nocp. However, we stored
the ACL transaction for every handle regardless of whether its known
or otherwise, so we have enough information to actually determine
whether the disconnection has Nocp issue.

This CL doesn't skip checking Nocp for unknown handle.

Bug: 293397988
Test: Test with report 91002174092
Change-Id: If4b768c56faaf22845d69fe044606eb830a403ba
parent 52d26253

floss/hcidoc/src/groups/connections.rs

+16 −21
Original line number Diff line number Diff line
@@ -292,8 +292,8 @@ impl OddDisconnectionsRule { 


            EventChild::DisconnectionComplete(dsc) => {

                let handle = dsc.get_connection_handle();

                match self.active_handles.remove(&handle) {

                    Some(_) => {

                self.active_handles.remove(&handle);



                // Check if this is a NOCP type disconnection and flag it.

                match self.nocp_by_handle.get_mut(&handle) {

                    Some(nocp_data) => {
@@ -312,11 +312,6 @@ impl OddDisconnectionsRule { 
                    }

                    None => (),

                }

                    }



                    // No issue if none, probably device is connected before snoop started.

                    None => (),

                }



                // Remove nocp information for handles that were removed.

                self.nocp_by_handle.remove(&handle);