Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 57075d60 authored by Jakub Pawlowski's avatar Jakub Pawlowski
Browse files

Don't use move in FOR_EACH_* macro 

FOR_EACH_* macros are resolved to for loop. Using std::move inside it
will cause already moved object to be used when more than one observer
is registered. This patch fixes that.

This issue was already fixed in commit 61d967af, but was reintroduced in
a835780b.

Change-Id: I14b72371d369e4bdcaf3a6e30045bf8a1e8c3e1b
parent b818e38b

system/service/hal/bluetooth_gatt_interface.cc

+1 −1
Original line number Diff line number Diff line
@@ -370,7 +370,7 @@ void RequestWriteCharacteristicCallback(int conn_id, int trans_id, 


  FOR_EACH_SERVER_OBSERVER(RequestWriteCharacteristicCallback(

      g_interface, conn_id, trans_id, *bda, attr_handle, offset,

      need_rsp, is_prep, std::move(value)));

      need_rsp, is_prep, value));

}



void RequestWriteDescriptorCallback(int conn_id, int trans_id,