Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 565cff48 authored by Chienyuan Huang's avatar Chienyuan Huang
Browse files

Fix controller test 

Bug: 259529416
Test: gd/cert/run
Test: bluetooth_test_gd_unit64 --gtest_filter="*Controller*"
Tag: #refactor
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: Ib5366391e5ee7ced89ef486f78a9cfbd03b780a9
parent b2a8f076

system/gd/hci/controller_test.cc

+29 −7
Original line number Diff line number Diff line
@@ -283,6 +283,7 @@ class TestHciLayer : public HciLayer { 
class ControllerTest : public ::testing::Test {

 protected:

  void SetUp() override {

    feature_spec_version = feature_spec_version_;

    bluetooth::common::InitFlags::SetAllForTesting();

    test_hci_layer_ = new TestHciLayer;

    fake_registry_.InjectTestModule(&HciLayer::Factory, test_hci_layer_);
@@ -300,6 +301,31 @@ class ControllerTest : public ::testing::Test { 
  os::Thread& thread_ = fake_registry_.GetTestThread();

  Controller* controller_ = nullptr;

  os::Handler* client_handler_ = nullptr;

  uint16_t feature_spec_version_ = 98;

};



class Controller055Test : public ControllerTest {

 protected:

  void SetUp() override {

    feature_spec_version_ = 55;

    ControllerTest::SetUp();

  }

};



class Controller095Test : public ControllerTest {

 protected:

  void SetUp() override {

    feature_spec_version_ = 95;

    ControllerTest::SetUp();

  }

};



class Controller096Test : public ControllerTest {

 protected:

  void SetUp() override {

    feature_spec_version_ = 96;

    ControllerTest::SetUp();

  }

};



TEST_F(ControllerTest, startup_teardown) {}
@@ -406,28 +432,25 @@ TEST_F(ControllerTest, is_supported_test) { 
  ASSERT_FALSE(controller_->IsSupported(OpCode::LE_SET_PERIODIC_ADVERTISING_PARAM));

}



TEST_F(ControllerTest, feature_spec_version_055_test) {

TEST_F(Controller055Test, feature_spec_version_055_test) {

  ASSERT_EQ(controller_->GetVendorCapabilities().version_supported_, 55);

  ASSERT_TRUE(controller_->IsSupported(OpCode::LE_MULTI_ADVT));

  ASSERT_FALSE(controller_->IsSupported(OpCode::CONTROLLER_DEBUG_INFO));

  ASSERT_FALSE(controller_->IsSupported(OpCode::CONTROLLER_A2DP_OPCODE));

  feature_spec_version = 95;

}



TEST_F(ControllerTest, feature_spec_version_095_test) {

TEST_F(Controller095Test, feature_spec_version_095_test) {

  ASSERT_EQ(controller_->GetVendorCapabilities().version_supported_, 95);

  ASSERT_TRUE(controller_->IsSupported(OpCode::LE_MULTI_ADVT));

  ASSERT_FALSE(controller_->IsSupported(OpCode::CONTROLLER_DEBUG_INFO));

  ASSERT_FALSE(controller_->IsSupported(OpCode::CONTROLLER_A2DP_OPCODE));

  feature_spec_version = 96;

}



TEST_F(ControllerTest, feature_spec_version_096_test) {

TEST_F(Controller096Test, feature_spec_version_096_test) {

  ASSERT_EQ(controller_->GetVendorCapabilities().version_supported_, 96);

  ASSERT_TRUE(controller_->IsSupported(OpCode::LE_MULTI_ADVT));

  ASSERT_FALSE(controller_->IsSupported(OpCode::CONTROLLER_DEBUG_INFO));

  ASSERT_FALSE(controller_->IsSupported(OpCode::CONTROLLER_A2DP_OPCODE));

  feature_spec_version = 98;

}



TEST_F(ControllerTest, feature_spec_version_098_test) {
@@ -435,7 +458,6 @@ TEST_F(ControllerTest, feature_spec_version_098_test) { 
  ASSERT_TRUE(controller_->IsSupported(OpCode::LE_MULTI_ADVT));

  ASSERT_FALSE(controller_->IsSupported(OpCode::CONTROLLER_DEBUG_INFO));

  ASSERT_TRUE(controller_->IsSupported(OpCode::CONTROLLER_A2DP_OPCODE));

  feature_spec_version = 55;

}



std::promise<void> credits1_set;