Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b427053 authored by Jeremy Wu's avatar Jeremy Wu
Browse files

Floss: update debug logs in |sco_pkt_read_ptr| 

The logic here is to drain all available data in the queue until it is
empty, and there is a debug log whenever an attempt to reading the queue
results in insufficient data. This spams report logs really bad because
at every cycle of SCO packet exchange there is this log.

This CL removes the log, with the rationale that if there is ever
insufficient data, the cause elsewhere should cover the logs.

Bug: 329298322
Test: m Bluetooth
Flag: EXEMPT floss only changes
Change-Id: I3439ca6a0ae2253c7c1b48db559b727923ace1e7
parent 15a1f5e5

system/stack/btm/btm_sco_hci.cc

+8 −4
Original line number Original line Diff line number Diff line
@@ -565,6 +565,10 @@ struct tBTM_MSBC_INFO { 




  size_t write(const std::vector<uint8_t>& input) {

  size_t write(const std::vector<uint8_t>& input) {

    if (input.size() > decode_buf_avail_len()) {

    if (input.size() > decode_buf_avail_len()) {

      log::warn(

          "Cannot write input with size {} into decode_buf with {} empty "

          "space.",

          input.size(), decode_buf_avail_len());

      return 0;

      return 0;

    }

    }
@@ -656,8 +660,6 @@ struct tBTM_MSBC_INFO { 




  const uint8_t* sco_pkt_read_ptr() {

  const uint8_t* sco_pkt_read_ptr() {

    if (encode_buf_wo - encode_buf_ro < packet_size) {

    if (encode_buf_wo - encode_buf_ro < packet_size) {

      log::debug("Insufficient data to dequeue. buf_wo:{}, buf_ro:{}",

                 encode_buf_wo, encode_buf_ro);

      return nullptr;

      return nullptr;

    }

    }
@@ -959,6 +961,10 @@ struct tBTM_LC3_INFO { 




  size_t write(const std::vector<uint8_t>& input) {

  size_t write(const std::vector<uint8_t>& input) {

    if (input.size() > buf_size - decode_buf_wo) {

    if (input.size() > buf_size - decode_buf_wo) {

      log::warn(

          "Cannot write input with size {} into decode_buf with {} empty "

          "space.",

          input.size(), buf_size - decode_buf_wo);

      return 0;

      return 0;

    }

    }
@@ -1007,8 +1013,6 @@ struct tBTM_LC3_INFO { 




  const uint8_t* sco_pkt_read_ptr() {

  const uint8_t* sco_pkt_read_ptr() {

    if (encode_buf_wo - encode_buf_ro < packet_size) {

    if (encode_buf_wo - encode_buf_ro < packet_size) {

      log::debug("Insufficient data to dequeue. buf_wo:{}, buf_ro:{}",

                 encode_buf_wo, encode_buf_ro);

      return nullptr;

      return nullptr;

    }

    }