Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b2932fb authored by Pavlin Radoslavov's avatar Pavlin Radoslavov
Browse files

Fix a crash for a race condition during Bluetooth shutdown 

This is same race condition observed in btif_media_task_aa_tx_flush_req()
because btif_media_task_aa_tx_flush_req() and btif_media_task_stop_aa_req()
are called back-to-bach.

This race condition is triggered when A2DP audio is streaming on shutdown:
"btif_a2dp_on_stopped() -> btif_media_task_stop_aa_req()" is called
to stop the particular audio stream, and this happens right after
the "cleanup() -> btif_a2dp_stop_media_task()" processing during
the shutdown of the Bluetooth stack.

Bug: 22700411
Change-Id: Ia0c98d44a108cf0f57731ac8129e4d76c9934542
parent 06be2317

system/btif/src/btif_media_task.c

+13 −1
Original line number Diff line number Diff line
@@ -1469,7 +1469,19 @@ BOOLEAN btif_media_task_stop_aa_req(void) 


    p_buf->event = BTIF_MEDIA_STOP_AA_TX;



    /*

     * Explicitly check whether the btif_media_cmd_msg_queue is not NULL to

     * avoid a race condition during shutdown of the Bluetooth stack.

     * This race condition is triggered when A2DP audio is streaming on

     * shutdown:

     * "btif_a2dp_on_stopped() -> btif_media_task_stop_aa_req()" is called

     * to stop the particular audio stream, and this happens right after

     * the "cleanup() -> btif_a2dp_stop_media_task()" processing during

     * the shutdown of the Bluetooth stack.

     */

    if (btif_media_cmd_msg_queue != NULL)

        fixed_queue_enqueue(btif_media_cmd_msg_queue, p_buf);



    return TRUE;

}

/*******************************************************************************