Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 461fd829 authored by Jakub Pawlowski's avatar Jakub Pawlowski
Browse files

Make sure server response doesn't exceed maximum allowable length 

Bug: 78787521
Test: try sending response bigger than BTGATT_MAX_ATTR_LEN
Change-Id: I51b12483cced7e4c0d967acf5bb42559ef169fe7
Merged-In: I51b12483cced7e4c0d967acf5bb42559ef169fe7
(cherry picked from commit 14b5d86a)
parent 2bca2560

android/app/jni/com_android_bluetooth_gatt.cpp

+7 −1
Original line number Diff line number Diff line
@@ -1681,7 +1681,13 @@ static void gattServerSendResponseNative(JNIEnv* env, jobject object, 
  response.attr_value.len = 0;



  if (val != NULL) {

    if (env->GetArrayLength(val) < BTGATT_MAX_ATTR_LEN) {

      response.attr_value.len = (uint16_t)env->GetArrayLength(val);

    } else {

      android_errorWriteLog(0x534e4554, "78787521");

      response.attr_value.len = BTGATT_MAX_ATTR_LEN;

    }



    jbyte* array = env->GetByteArrayElements(val, 0);



    for (int i = 0; i != response.attr_value.len; ++i)