Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 45f218b9 authored by Josh Wu's avatar Josh Wu Committed by Soma Jagannathan
Browse files

Metric: Log extended smp pairing events 

Include transport and complete information in extended enums.

Tag: #refactor
Bug: 263323082
Bug: 236677941
Test: atest gd/cert/run
Change-Id: I6e527d8ad8b9dfa91b8abf67a9faa0fb11a513fb
(cherry picked from commit 2f74a3c2)
Merged-In: I6e527d8ad8b9dfa91b8abf67a9faa0fb11a513fb
parent eab45bd0

system/gd/os/android/metrics.cc

+1 −1
Original line number Original line Diff line number Diff line
@@ -236,7 +236,7 @@ void LogMetricReadTxPowerLevelResult( 
}

}





void LogMetricSmpPairingEvent(

void LogMetricSmpPairingEvent(

    const Address& address, uint8_t smp_cmd, android::bluetooth::DirectionEnum direction, uint8_t smp_fail_reason) {

    const Address& address, uint16_t smp_cmd, android::bluetooth::DirectionEnum direction, uint16_t smp_fail_reason) {

  int metric_id = 0;

  int metric_id = 0;

  if (!address.IsEmpty()) {

  if (!address.IsEmpty()) {

    metric_id = MetricIdManager::GetInstance().AllocateId(address);

    metric_id = MetricIdManager::GetInstance().AllocateId(address);

system/gd/os/host/metrics.cc

+1 −1
Original line number Original line Diff line number Diff line
@@ -96,7 +96,7 @@ void LogMetricSdpAttribute( 
    const char* attribute_value) {}

    const char* attribute_value) {}





void LogMetricSmpPairingEvent(

void LogMetricSmpPairingEvent(

    const Address& address, uint8_t smp_cmd, android::bluetooth::DirectionEnum direction, uint8_t smp_fail_reason) {}

    const Address& address, uint16_t smp_cmd, android::bluetooth::DirectionEnum direction, uint16_t smp_fail_reason) {}





void LogMetricA2dpPlaybackEvent(const Address& address, int playback_state, int audio_coding_mode) {}

void LogMetricA2dpPlaybackEvent(const Address& address, int playback_state, int audio_coding_mode) {}

system/gd/os/linux/metrics.cc

+1 −1
Original line number Original line Diff line number Diff line
@@ -96,7 +96,7 @@ void LogMetricSdpAttribute( 
    const char* attribute_value) {}

    const char* attribute_value) {}





void LogMetricSmpPairingEvent(

void LogMetricSmpPairingEvent(

    const Address& address, uint8_t smp_cmd, android::bluetooth::DirectionEnum direction, uint8_t smp_fail_reason) {}

    const Address& address, uint16_t smp_cmd, android::bluetooth::DirectionEnum direction, uint16_t smp_fail_reason) {}





void LogMetricA2dpPlaybackEvent(const Address& address, int playback_state, int audio_coding_mode) {}

void LogMetricA2dpPlaybackEvent(const Address& address, int playback_state, int audio_coding_mode) {}

system/gd/os/metrics.h

+4 −1
Original line number Original line Diff line number Diff line
@@ -166,7 +166,10 @@ void LogMetricReadTxPowerLevelResult( 
 * @param smp_fail_reason SMP pairing failure reason code from SMP spec

 * @param smp_fail_reason SMP pairing failure reason code from SMP spec

 */

 */

void LogMetricSmpPairingEvent(

void LogMetricSmpPairingEvent(

    const hci::Address& address, uint8_t smp_cmd, android::bluetooth::DirectionEnum direction, uint8_t smp_fail_reason);

    const hci::Address& address,

    uint16_t smp_cmd,

    android::bluetooth::DirectionEnum direction,

    uint16_t smp_fail_reason);





/**

/**

 * Logs there is an event related Bluetooth classic pairing

 * Logs there is an event related Bluetooth classic pairing

system/main/shim/metrics_api.cc

+2 −2
Original line number Original line Diff line number Diff line
@@ -89,9 +89,9 @@ void LogMetricReadTxPowerLevelResult(const RawAddress& raw_address, 
                                                 transmit_power_level);

                                                 transmit_power_level);

}

}





void LogMetricSmpPairingEvent(const RawAddress& raw_address, uint8_t smp_cmd,

void LogMetricSmpPairingEvent(const RawAddress& raw_address, uint16_t smp_cmd,

                              android::bluetooth::DirectionEnum direction,

                              android::bluetooth::DirectionEnum direction,

                              uint8_t smp_fail_reason) {

                              uint16_t smp_fail_reason) {

  Address address = bluetooth::ToGdAddress(raw_address);

  Address address = bluetooth::ToGdAddress(raw_address);

  bluetooth::os::LogMetricSmpPairingEvent(address, smp_cmd, direction,

  bluetooth::os::LogMetricSmpPairingEvent(address, smp_cmd, direction,

                                          smp_fail_reason);

                                          smp_fail_reason);