Remove gd_hal_snoop_logger_socket feature flag (4538b82d) · Commits · e / os / android_packages_modules_Bluetooth

system/gd/common/init_flags.h

+0 −4

Original line number	Diff line number	Diff line
		@@ -52,10 +52,6 @@ class InitFlags final {
		return init_flags::btm_dm_flush_discovery_queue_on_search_cancel_is_enabled();
		}

		inline static bool IsSnoopLoggerSocketEnabled() {
		return init_flags::gd_hal_snoop_logger_socket_is_enabled();
		}

		inline static bool IsBluetoothQualityReportCallbackEnabled() {
		return init_flags::bluetooth_quality_report_callback_is_enabled();
		}

+0 −6

Original line number	Diff line number	Diff line
		@@ -87,12 +87,6 @@ TEST(InitFlagsTest, test_debug_logging_multiple_flags) {
		ASSERT_EQ(InitFlags::GetDefaultLogLevel(), LOG_TAG_WARN);
		}

		TEST(InitFlagsTest, test_enable_snoop_logger_socket) {
		const char* input[] = {"INIT_gd_hal_snoop_logger_socket=true", nullptr};
		InitFlags::Load(input);
		ASSERT_TRUE(InitFlags::IsSnoopLoggerSocketEnabled());
		}

		TEST(InitFlagsTest, test_device_iot_config_logging_is_enabled) {
		const char* input[] = {"INIT_device_iot_config_logging=true", nullptr};
		InitFlags::Load(input);

+11 −12

Original line number	Diff line number	Diff line
		@@ -1322,9 +1322,9 @@ void SnoopLogger::Start() {
		EnableFilters();
		}

		if (bluetooth::common::InitFlags::IsSnoopLoggerSocketEnabled()) {
		auto snoop_logger_socket = std::make_unique<SnoopLoggerSocket>(&syscall_if);
		snoop_logger_socket_thread_ = std::make_unique<SnoopLoggerSocketThread>(std::move(snoop_logger_socket));
		snoop_logger_socket_thread_ =
		std::make_unique<SnoopLoggerSocketThread>(std::move(snoop_logger_socket));
		auto thread_started_future = snoop_logger_socket_thread_->Start();
		thread_started_future.wait();
		if (thread_started_future.get()) {
		@@ -1335,7 +1335,6 @@ void SnoopLogger::Start() {
		snoop_logger_socket_thread_ = nullptr;
		}
		}
		}
		alarm_ = std::make_unique<os::RepeatingAlarm>(GetHandler());
		alarm_->Schedule(
		common::Bind(&delete_old_btsnooz_files, snooz_log_path_, snooz_log_life_time_), snooz_log_delete_alarm_interval_);

+0 −1

Original line number	Diff line number	Diff line
		@@ -115,7 +115,6 @@ using namespace std::chrono_literals;

		const char* test_flags[] = {
		"INIT_logging_debug_enabled_for_all=true",
		"INIT_gd_hal_snoop_logger_socket=true",
		nullptr,
		};

+0 −1

Original line number	Diff line number	Diff line
		@@ -375,7 +375,6 @@ init_flags!(
		gatt_robust_caching_client = true,
		gatt_robust_caching_server,
		gd_core,
		gd_hal_snoop_logger_socket = true,
		gd_l2cap,
		gd_link_policy,
		gd_rust,