Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4038e37a authored by William Escande's avatar William Escande
Browse files

VCP: silence gmock warning in test 

The huge amount of GMOCK WARNING is making very difficult to look at the
test logs without loosing my patience
Since we don't care about its return value and don't want to enforce a
strict mode, it make sense to use a nice mock

Bug: 372328699
Flag: com.android.bluetooth.flags.aics_api
Test: atest bluetooth_vc_test
Change-Id: I0decbb7f6b36b6f4b9f914591d8dd3689e6b32fe
parent cb90118c

system/bta/vc/devices_test.cc

+6 −5
Original line number Diff line number Diff line
@@ -44,6 +44,7 @@ using ::testing::_; 
using ::testing::DoAll;

using ::testing::Invoke;

using ::testing::Mock;

using ::testing::NiceMock;

using ::testing::Return;

using ::testing::SaveArg;

using ::testing::SetArgPointee;
@@ -74,8 +75,8 @@ protected: 
  }



  VolumeControlDevices* devices_ = nullptr;

  gatt::MockBtaGattInterface gatt_interface;

  gatt::MockBtaGattQueue gatt_queue;

  NiceMock<gatt::MockBtaGattInterface> gatt_interface;

  NiceMock<gatt::MockBtaGattQueue> gatt_queue;

};



TEST_F(VolumeControlDevicesTest, test_add) {
@@ -361,9 +362,9 @@ protected: 
  }



  VolumeControlDevice* device = nullptr;

  gatt::MockBtaGattInterface gatt_interface;

  gatt::MockBtaGattQueue gatt_queue;

  bluetooth::manager::MockBtmInterface btm_interface;

  NiceMock<gatt::MockBtaGattInterface> gatt_interface;

  NiceMock<gatt::MockBtaGattQueue> gatt_queue;

  NiceMock<bluetooth::manager::MockBtmInterface> btm_interface;

  std::list<gatt::Service> services;

};

system/bta/vc/vc_test.cc

+139 −138

File changed.

Preview size limit exceeded, changes collapsed.