Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e4d2088 authored by Chris Manton's avatar Chris Manton Committed by Automerger Merge Worker
Browse files

Clean up unused param warnings cert facade am: 078e2faf 

Original change: https://android-review.googlesource.com/c/platform/packages/modules/Bluetooth/+/2769046



Change-Id: I602255b2f2b489202b16b1fd09000f0e9d398369
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents a565575b 078e2faf

system/gd/facade/facade_main.cc

+1 −1
Original line number Diff line number Diff line
@@ -70,7 +70,7 @@ void interrupt_handler(int signal_number) { 
}

struct sigaction new_act = {.sa_handler = interrupt_handler};



bool crash_callback(const void* crash_context, size_t crash_context_size, void* context) {

bool crash_callback(const void* crash_context, size_t crash_context_size, void* /* context */) {

  std::optional<pid_t> tid;

  if (crash_context_size >= sizeof(google_breakpad::ExceptionHandler::CrashContext)) {

    auto* ctx = static_cast<const google_breakpad::ExceptionHandler::CrashContext*>(crash_context);

system/gd/facade/grpc_root_server.cc

+5 −5
Original line number Diff line number Diff line
@@ -51,9 +51,9 @@ class RootFacadeService : public ::blueberry::facade::RootFacade::Service { 
  explicit RootFacadeService(int grpc_port) : grpc_port_(grpc_port) {}



  ::grpc::Status StartStack(

      ::grpc::ServerContext* context,

      ::grpc::ServerContext* /* context */,

      const ::blueberry::facade::StartStackRequest* request,

      ::blueberry::facade::StartStackResponse* response) override {

      ::blueberry::facade::StartStackResponse* /* response */) override {

    if (is_running_) {

      return ::grpc::Status(::grpc::StatusCode::INVALID_ARGUMENT, "stack is running");

    }
@@ -124,9 +124,9 @@ class RootFacadeService : public ::blueberry::facade::RootFacade::Service { 
  }



  ::grpc::Status StopStack(

      ::grpc::ServerContext* context,

      const ::blueberry::facade::StopStackRequest* request,

      ::blueberry::facade::StopStackResponse* response) override {

      ::grpc::ServerContext* /* context */,

      const ::blueberry::facade::StopStackRequest* /* request */,

      ::blueberry::facade::StopStackResponse* /* response */) override {

    if (!is_running_) {

      return ::grpc::Status(::grpc::StatusCode::INVALID_ARGUMENT, "stack is not running");

    }

system/gd/facade/read_only_property_server.cc

+2 −2
Original line number Diff line number Diff line
@@ -25,8 +25,8 @@ class ReadOnlyPropertyService : public blueberry::facade::ReadOnlyProperty::Serv 
 public:

  ReadOnlyPropertyService(hci::Controller* controller) : controller_(controller) {}

  ::grpc::Status ReadLocalAddress(

      ::grpc::ServerContext* context,

      const ::google::protobuf::Empty* request,

      ::grpc::ServerContext* /* context */,

      const ::google::protobuf::Empty* /* request */,

      ::blueberry::facade::BluetoothAddress* response) override {

    auto address = controller_->GetMacAddress().ToString();

    response->set_address(address);

system/gd/grpc/grpc_module.cc

+1 −1
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ using ::grpc::ServerBuilder; 
namespace bluetooth {

namespace grpc {



void GrpcModule::ListDependencies(ModuleList* list) const {}

void GrpcModule::ListDependencies(ModuleList* /* list */) const {}



void GrpcModule::Start() {

  ASSERT(!started_);

system/gd/hal/facade.cc

+10 −10
Original line number Diff line number Diff line
@@ -42,9 +42,9 @@ class HciHalFacadeService : public blueberry::facade::hal::HciHalFacade::Service 
  }



  ::grpc::Status SendCommand(

      ::grpc::ServerContext* context,

      ::grpc::ServerContext* /* context */,

      const ::blueberry::facade::Data* request,

      ::google::protobuf::Empty* response) override {

      ::google::protobuf::Empty* /* response */) override {

    std::unique_lock<std::mutex> lock(mutex_);

    can_send_hci_command_ = false;

    std::string req_string = request->payload();
@@ -56,18 +56,18 @@ class HciHalFacadeService : public blueberry::facade::hal::HciHalFacade::Service 
  }



  ::grpc::Status SendAcl(

      ::grpc::ServerContext* context,

      ::grpc::ServerContext* /* context */,

      const ::blueberry::facade::Data* request,

      ::google::protobuf::Empty* response) override {

      ::google::protobuf::Empty* /* response */) override {

    std::string req_string = request->payload();

    hal_->sendAclData(std::vector<uint8_t>(req_string.begin(), req_string.end()));

    return ::grpc::Status::OK;

  }



  ::grpc::Status SendSco(

      ::grpc::ServerContext* context,

      ::grpc::ServerContext* /* context */,

      const ::blueberry::facade::Data* request,

      ::google::protobuf::Empty* response) override {

      ::google::protobuf::Empty* /* response */) override {

    std::string req_string = request->payload();

    hal_->sendScoData(std::vector<uint8_t>(req_string.begin(), req_string.end()));

    return ::grpc::Status::OK;
@@ -75,28 +75,28 @@ class HciHalFacadeService : public blueberry::facade::hal::HciHalFacade::Service 


  ::grpc::Status StreamEvents(

      ::grpc::ServerContext* context,

      const ::google::protobuf::Empty* request,

      const ::google::protobuf::Empty* /* request */,

      ::grpc::ServerWriter<::blueberry::facade::Data>* writer) override {

    return pending_hci_events_.RunLoop(context, writer);

  };



  ::grpc::Status StreamAcl(

      ::grpc::ServerContext* context,

      const ::google::protobuf::Empty* request,

      const ::google::protobuf::Empty* /* request */,

      ::grpc::ServerWriter<::blueberry::facade::Data>* writer) override {

    return pending_acl_events_.RunLoop(context, writer);

  };



  ::grpc::Status StreamSco(

      ::grpc::ServerContext* context,

      const ::google::protobuf::Empty* request,

      const ::google::protobuf::Empty* /* request */,

      ::grpc::ServerWriter<::blueberry::facade::Data>* writer) override {

    return pending_sco_events_.RunLoop(context, writer);

  };



  ::grpc::Status StreamIso(

      ::grpc::ServerContext* context,

      const ::google::protobuf::Empty* request,

      const ::google::protobuf::Empty* /* request */,

      ::grpc::ServerWriter<::blueberry::facade::Data>* writer) override {

    return pending_iso_events_.RunLoop(context, writer);

  };