Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 39b32b24 authored by Manoj Gupta's avatar Manoj Gupta
Browse files

Bluetooth: Fix errors found with clang ToT 

Fix some of the errors found with clang ToT.

system/gd/common/strings.cc:51:15: error: no member named
'find_if_not' in namespace 'std'

bt/system/gd/hci/hci_layer.h:139:27: error: unqualified call
to std::move [-Werror,-Wunqualified-std-cast-call]

The failure was noticed in ChromeOS tot llvm builds where this
repo is imported.

Bug: 228085014
Test: errors are fixed

Change-Id: I53bf7870ec6294d82f901affbdabf9c4f2b6d9ac
parent c084da6b

system/gd/common/strings.cc

+2 −1
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


#include "common/strings.h"



#include <algorithm>

#include <charconv>

#include <cstdlib>

#include <functional>

system/gd/hci/hci_layer.h

+6 −2
Original line number Diff line number Diff line
@@ -17,7 +17,11 @@ 
#pragma once



#include <chrono>

#include <list>

#include <map>

#include <memory>

#include <string>

#include <utility>



#include "address.h"

#include "class_of_device.h"
@@ -136,12 +140,12 @@ class HciLayer : public Module, public CommandInterface<CommandBuilder> { 


    void EnqueueCommand(std::unique_ptr<T> command,

                        common::ContextualOnceCallback<void(CommandCompleteView)> on_complete) override {

      hci_.EnqueueCommand(move(command), std::move(on_complete));

      hci_.EnqueueCommand(std::move(command), std::move(on_complete));

    }



    void EnqueueCommand(std::unique_ptr<T> command,

                        common::ContextualOnceCallback<void(CommandStatusView)> on_status) override {

      hci_.EnqueueCommand(move(command), std::move(on_status));

      hci_.EnqueueCommand(std::move(command), std::move(on_status));

    }

    HciLayer& hci_;

  };

system/gd/module.h

+2 −0
Original line number Diff line number Diff line
@@ -17,10 +17,12 @@ 
#pragma once



#include <flatbuffers/flatbuffers.h>

#include <chrono>

#include <functional>

#include <future>

#include <map>

#include <string>

#include <utility>

#include <vector>



#include "common/bind.h"