Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3939ac52 authored by Chris Manton's avatar Chris Manton
Browse files

dumpsys: Extract flatbuffer to allow additional implementations 

Bug: 317135880
Test: atest bluetooth_test_gdx_unit
Flag: EXEMPT, test infrastructure

Change-Id: Ia172cb23ab0c852d34d0a5ea5d57eba5a77a1d25
parent d1e37cda

system/gd/Android.bp

+2 −1
Original line number Diff line number Diff line
@@ -148,7 +148,7 @@ cc_defaults { 
        ":BluetoothSyspropsSources",

        "module.cc",

        "module_dumper.cc",

        "module_dumper_flatbuffer.cc",

        "module_state_dumper.cc",

        "stack_manager.cc",

    ],

    generated_headers: [
@@ -463,6 +463,7 @@ cc_test { 
        "module_gdx_unittest.cc",

        "module_jniloop_unittest.cc",

        "module_mainloop_unittest.cc",

        "module_state_dumper_unittest.cc",

    ],

    generated_headers: [

        "BluetoothGeneratedBundlerSchema_h_bfbs",

system/gd/BUILD.gn

+1 −1
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ static_library("libbluetooth_gd") { 
  sources = [

    "module.cc",

    "module_dumper.cc",

    "module_dumper_flatbuffer.cc",

    "module_state_dumper.cc",

    "stack_manager.cc",

  ]

system/gd/hci/controller_test.cc

+5 −2
Original line number Diff line number Diff line
@@ -17,10 +17,12 @@ 
#include "hci/controller.h"



#include <gtest/gtest.h>

#include <unistd.h>



#include <chrono>

#include <future>

#include <memory>

#include <sstream>



#include "common/bind.h"

#include "common/init_flags.h"
@@ -532,10 +534,11 @@ TEST_F(ControllerTest, leRandTest) { 
}



TEST_F(ControllerTest, Dumpsys) {

  ModuleDumper dumper(fake_registry_, title);

  ModuleDumper dumper(STDOUT_FILENO, fake_registry_, title);



  std::string output;

  dumper.DumpState(&output);

  std::ostringstream oss;

  dumper.DumpState(&output, oss);



  ASSERT_TRUE(output.find("Hci Controller Dumpsys") != std::string::npos);

}

system/gd/module.cc

+0 −5
Original line number Diff line number Diff line
@@ -18,7 +18,6 @@ 
#include "module.h"



#include "common/init_flags.h"

#include "module_dumper_flatbuffer.h"



using ::bluetooth::os::Handler;

using ::bluetooth::os::Thread;
@@ -35,10 +34,6 @@ Handler* Module::GetHandler() const { 
  return handler_;

}



DumpsysDataFinisher Module::GetDumpsysData(flatbuffers::FlatBufferBuilder* /* builder */) const {

  return EmptyDumpsysDataFinisher;

}



const ModuleRegistry* Module::GetModuleRegistry() const {

  return registry_;

}

system/gd/module.h

+2 −8
Original line number Diff line number Diff line
@@ -16,7 +16,6 @@ 


#pragma once



#include <flatbuffers/flatbuffers.h>

#include <chrono>

#include <functional>

#include <future>
@@ -26,7 +25,7 @@ 
#include <vector>



#include "common/bind.h"

#include "dumpsys_data_generated.h"

#include "module_state_dumper.h"

#include "os/handler.h"

#include "os/log.h"

#include "os/thread.h"
@@ -64,8 +63,6 @@ public: 
  std::vector<const ModuleFactory*> list_;

};



using DumpsysDataFinisher = std::function<void(DumpsysDataBuilder* dumpsys_data_builder)>;



// Each leaf node module must have a factory like so:

//

// static const ModuleFactory Factory;
@@ -73,7 +70,7 @@ using DumpsysDataFinisher = std::function<void(DumpsysDataBuilder* dumpsys_data_ 
// which will provide a constructor for the module registry to call.

// The module registry will also use the factory as the identifier

// for that module.

class Module {

class Module : protected ModuleStateDumper {

  friend ModuleDumper;

  friend ModuleRegistry;

  friend TestModuleRegistry;
@@ -91,9 +88,6 @@ class Module { 
  // Release all resources, you're about to be deleted

  virtual void Stop() = 0;



  // Get relevant state data from the module

  virtual DumpsysDataFinisher GetDumpsysData(flatbuffers::FlatBufferBuilder* builder) const;



  virtual std::string ToString() const = 0;



  ::bluetooth::os::Handler* GetHandler() const;