Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38d72d23 authored by Henri Chataing's avatar Henri Chataing Committed by Automerger Merge Worker
Browse files

Merge "Fix tidy build breakage" am: 5650f5cc am: 5f164002 

Original change: https://android-review.googlesource.com/c/platform/packages/modules/Bluetooth/+/2368352



Change-Id: I3a8bf47036cdaf376a889b16eec2f437cec50621
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents acb05f3e 5f164002

tools/rootcanal/include/hci/pcap_filter.h

+0 −3
Original line number Diff line number Diff line
@@ -49,9 +49,6 @@ class PcapFilter final { 


  std::vector<uint8_t> FilterHciCommand(std::vector<uint8_t> const& packet);

  std::vector<uint8_t> FilterHciEvent(std::vector<uint8_t> const& packet);

  std::vector<uint8_t> FilterHciAcl(std::vector<uint8_t> const& packet) const;

  std::vector<uint8_t> FilterHciSco(std::vector<uint8_t> const& packet) const;

  std::vector<uint8_t> FilterHciIso(std::vector<uint8_t> const& packet) const;



 private:

  // Specific filters for HCI commands.

tools/rootcanal/lib/hci/pcap_filter.cc

+7 −6
Original line number Diff line number Diff line
@@ -34,6 +34,10 @@ static PacketView<kLittleEndian> create_packet_view( 
      &packet, [](std::vector<uint8_t> const* /* ptr */) {}));

}



static std::vector<uint8_t> FilterHciAcl(std::vector<uint8_t> const& packet);

static std::vector<uint8_t> FilterHciSco(std::vector<uint8_t> const& packet);

static std::vector<uint8_t> FilterHciIso(std::vector<uint8_t> const& packet);



std::vector<uint8_t> PcapFilter::FilterHciPacket(

    std::vector<uint8_t> const& packet, uint8_t idc) {

  switch (idc) {
@@ -133,8 +137,7 @@ std::vector<uint8_t> PcapFilter::FilterHciEvent( 
  return std::vector<uint8_t>(packet);

}



std::vector<uint8_t> PcapFilter::FilterHciAcl(

    std::vector<uint8_t> const& packet) const {

static std::vector<uint8_t> FilterHciAcl(std::vector<uint8_t> const& packet) {

  auto acl = AclView::Create(create_packet_view(packet));

  std::vector<uint8_t> payload;

  payload.resize(acl.GetPayload().size());
@@ -145,8 +148,7 @@ std::vector<uint8_t> PcapFilter::FilterHciAcl( 
      ->SerializeToBytes();

}



std::vector<uint8_t> PcapFilter::FilterHciSco(

    std::vector<uint8_t> const& packet) const {

static std::vector<uint8_t> FilterHciSco(std::vector<uint8_t> const& packet) {

  auto sco = ScoView::Create(create_packet_view(packet));

  std::vector<uint8_t> data;

  data.resize(sco.GetData().size());
@@ -155,8 +157,7 @@ std::vector<uint8_t> PcapFilter::FilterHciSco( 
      ->SerializeToBytes();

}



std::vector<uint8_t> PcapFilter::FilterHciIso(

    std::vector<uint8_t> const& packet) const {

static std::vector<uint8_t> FilterHciIso(std::vector<uint8_t> const& packet) {

  auto iso = IsoView::Create(create_packet_view(packet));

  std::vector<uint8_t> payload;

  payload.resize(iso.GetPayload().size());