Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34d8a79d authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "Add the appropriate statement to "case:" without "break""

parents 259122f1 4fa3f8c8

system/stack/gatt/gatt_api.cc

+1 −1
Original line number Diff line number Diff line
@@ -803,7 +803,7 @@ tGATT_STATUS GATTC_Read (uint16_t conn_id, tGATT_READ_TYPE type, tGATT_READ_PARA 
                    (tGATT_READ_MULTI *)osi_malloc(sizeof(tGATT_READ_MULTI));

                p_clcb->p_attr_buf = (uint8_t*)p_read_multi;

                memcpy(p_read_multi, &p_read->read_multiple, sizeof(tGATT_READ_MULTI));

                /* TODO: Missing "break" statement! */

                break;

            }

            case GATT_READ_BY_HANDLE:

            case GATT_READ_PARTIAL:

system/stack/gatt/gatt_db.cc

+2 −3
Original line number Diff line number Diff line
@@ -826,11 +826,10 @@ tGATT_STATUS gatts_write_attr_perm_check (tGATT_SVC_DB *p_db, uint8_t op_code, 
                            break;



                        case GATT_UUID_CHAR_CLIENT_CONFIG:

/* coverity[MISSING_BREAK] */

/* intnended fall through, ignored */

                            /* fall through */

                        case GATT_UUID_CHAR_SRVR_CONFIG:

                            max_size = 2;

                            /* fall through */

                        case GATT_UUID_CHAR_DESCRIPTION:

                        default: /* any other must be character value declaration */

                            status = GATT_SUCCESS;

system/stack/gatt/gatt_utils.cc

+1 −0
Original line number Diff line number Diff line
@@ -1121,6 +1121,7 @@ bool gatt_parse_uuid_from_cmd(tBT_UUID *p_uuid_rec, uint16_t uuid_size, uint8 
        /* do not allow 32 bits UUID in ATT PDU now */

        case LEN_UUID_32:

            GATT_TRACE_ERROR("DO NOT ALLOW 32 BITS UUID IN ATT PDU");

            return false;

        case 0:

        default:

            if (uuid_size != 0) ret = false;