Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3213932a authored by David Duarte's avatar David Duarte
Browse files

{HidDevice,Pan}Service: Use explicit looper 

The default constructor of Handler use Looper.myLooper(), which
in Services is Looper.getMainLooper(). This constructor is
deprecated because implicit loopers are errorprone.

Bug: 305741984
Test: m com.android.btservices
Change-Id: I8f60f5c89350a15dc741441ec10c18819797c756
parent 55ada0fb

android/app/src/com/android/bluetooth/hid/HidDeviceService.java

+6 −1
Original line number Original line Diff line number Diff line
@@ -32,6 +32,7 @@ import android.content.Intent; 
import android.os.Binder;

import android.os.Binder;

import android.os.Handler;

import android.os.Handler;

import android.os.IBinder;

import android.os.IBinder;

import android.os.Looper;

import android.os.Message;

import android.os.Message;

import android.os.Process;

import android.os.Process;

import android.os.RemoteException;

import android.os.RemoteException;
@@ -91,6 +92,10 @@ public class HidDeviceService extends ProfileService { 
    }

    }





    private class HidDeviceServiceHandler extends Handler {

    private class HidDeviceServiceHandler extends Handler {

        HidDeviceServiceHandler(Looper looper) {

            super(looper);

        }



        @Override

        @Override

        public void handleMessage(Message msg) {

        public void handleMessage(Message msg) {

            if (DBG) {

            if (DBG) {
@@ -770,7 +775,7 @@ public class HidDeviceService extends ProfileService { 
        mDatabaseManager = Objects.requireNonNull(AdapterService.getAdapterService().getDatabase(),

        mDatabaseManager = Objects.requireNonNull(AdapterService.getAdapterService().getDatabase(),

                "DatabaseManager cannot be null when HidDeviceService starts");

                "DatabaseManager cannot be null when HidDeviceService starts");





        mHandler = new HidDeviceServiceHandler();

        mHandler = new HidDeviceServiceHandler(Looper.getMainLooper());

        mHidDeviceNativeInterface = HidDeviceNativeInterface.getInstance();

        mHidDeviceNativeInterface = HidDeviceNativeInterface.getInstance();

        mHidDeviceNativeInterface.init();

        mHidDeviceNativeInterface.init();

        mNativeAvailable = true;

        mNativeAvailable = true;

android/app/src/com/android/bluetooth/pan/PanService.java

+1 −1
Original line number Original line Diff line number Diff line
@@ -215,7 +215,7 @@ public class PanService extends ProfileService { 
    }

    }





    private final Handler mHandler =

    private final Handler mHandler =

            new Handler() {

            new Handler(Looper.getMainLooper()) {

                @Override

                @Override

                public void handleMessage(Message msg) {

                public void handleMessage(Message msg) {

                    switch (msg.what) {

                    switch (msg.what) {