Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3153fa1a authored by Myles Watson's avatar Myles Watson
Browse files

HCI: Accept erroneous ConnectionComplete 

Some controllers send ConnectionComplete with status code
Unknown Connection when cancelling a RemoteNameRequest.

Fixes: 184239841
Tag: #gd-refactor
Test: cert/run
Change-Id: Ibcaf68a13e18a629ab16be3bb4bfe9c1ff208095
parent b051c7eb

system/gd/hci/acl_manager/classic_impl.h

+5 −0
Original line number Diff line number Diff line
@@ -240,6 +240,11 @@ struct classic_impl : public security::ISecurityManagerListener { 
      outgoing_connecting_address_ = Address::kEmpty;

    } else {

      locally_initiated = false;

      if (incoming_connecting_address_ != address && status == ErrorCode::UNKNOWN_CONNECTION) {

        LOG_WARN("No matching connection to %s (%s)", address.ToString().c_str(), ErrorCodeText(status).c_str());

        LOG_WARN("Firmware error after RemoteNameRequestCancel?");

        return;

      }

      ASSERT_LOG(incoming_connecting_address_ == address, "No prior connection request for %s",

                 address.ToString().c_str());

      incoming_connecting_address_ = Address::kEmpty;