Commit 2e0d34a0 authored Oct 31, 2024 by Etienne Ruffieux

Add missing return in GetMediaPlayerListResponse

There was a missing return in GetMediaPlayerListResponse resulting in
two messages sent if no player was available (one with error code,
the other with no error and empty players list).
We should only return RANGE_OUT_OF_BOUNDS when it's the case.

Bug: 328847183
Flag: exempt trivial
Test: atest BluetoothInstrumentationTests
Change-Id: I26637d4a310ba3b06c21d9d1d1f210351abd4f81

parent a8eeda6c

system/profile/avrcp/device.cc

+1 −0

Original line number	Diff line number	Diff line
		@@ -1364,6 +1364,7 @@ void Device::GetMediaPlayerListResponse(uint8_t label, std::shared_ptr<GetFolder
		auto no_items_rsp = GetFolderItemsResponseBuilder::MakePlayerListBuilder(
		Status::RANGE_OUT_OF_BOUNDS, 0x0000, browse_mtu_);
		send_message(label, true, std::move(no_items_rsp));
		return;
		}

		auto builder = GetFolderItemsResponseBuilder::MakePlayerListBuilder(Status::NO_ERROR, 0x0000,