Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ddf7ae8 authored by Łukasz Rymanowski's avatar Łukasz Rymanowski
Browse files

Remove leaudio_broadcast_assistant_handle_command_statuses flag 

Bug: 330492580
Bug: 331167629
Test: atest PeriodicSyncManagerTest --host
Flag: com.android.bluetooth.flags.leaudio_broadcast_assistant_handle_command_statuses
Change-Id: Ic1ed5769e43064950aa8a2bccefcd4f9fea90c01
parent a0b54258

flags/leaudio.aconfig

+0 −10
Original line number Diff line number Diff line
@@ -158,16 +158,6 @@ flag { 
    }

}



flag {

    name: "leaudio_broadcast_assistant_handle_command_statuses"

    namespace: "bluetooth"

    description: "Handle command statuses to recover from errors"

    bug: "331167629"

    metadata {

        purpose: PURPOSE_BUGFIX

    }

}



flag {

    name: "leaudio_getting_active_state_support"

    namespace: "bluetooth"

system/gd/hci/le_periodic_sync_manager.h

+0 −6
Original line number Diff line number Diff line
@@ -203,9 +203,6 @@ public: 


  template <class View>

  void HandlePeriodicAdvertisingCreateSyncStatus(CommandStatusView view) {

    if (!com::android::bluetooth::flags::leaudio_broadcast_assistant_handle_command_statuses()) {

      return;

    }

    log::assert_that(view.IsValid(), "assert failed: view.IsValid()");

    auto status_view = View::Create(view);

    log::assert_that(status_view.IsValid(), "assert failed: status_view.IsValid()");
@@ -238,9 +235,6 @@ public: 


  template <class View>

  void HandlePeriodicAdvertisingCreateSyncCancelStatus(CommandCompleteView view) {

    if (!com::android::bluetooth::flags::leaudio_broadcast_assistant_handle_command_statuses()) {

      return;

    }

    log::assert_that(view.IsValid(), "assert failed: view.IsValid()");

    auto status_view = View::Create(view);

    log::assert_that(status_view.IsValid(), "assert failed: status_view.IsValid()");

system/gd/hci/le_periodic_sync_manager_test.cc

+4 −8
Original line number Diff line number Diff line
@@ -605,10 +605,8 @@ TEST_F_WITH_FLAGS(PeriodicSyncManagerTest, handle_advertising_sync_established_a 
  sync_handler();

}



TEST_F_WITH_FLAGS(PeriodicSyncManagerTest,

                  handle_advertising_sync_established_after_create_command_error_test,

                  REQUIRES_FLAGS_ENABLED(ACONFIG_FLAG(

                          TEST_BT, leaudio_broadcast_assistant_handle_command_statuses))) {

TEST_F(PeriodicSyncManagerTest,

       handle_advertising_sync_established_after_create_command_error_test) {

  uint16_t sync_handle = 0x12;

  Address address;

  Address::FromString("00:11:22:33:44:55", address);
@@ -674,10 +672,8 @@ TEST_F_WITH_FLAGS(PeriodicSyncManagerTest, 
  sync_handler();

}



TEST_F_WITH_FLAGS(PeriodicSyncManagerTest,

                  handle_advertising_sync_established_after_cancel_command_error_test,

                  REQUIRES_FLAGS_ENABLED(ACONFIG_FLAG(

                          TEST_BT, leaudio_broadcast_assistant_handle_command_statuses))) {

TEST_F(PeriodicSyncManagerTest,

       handle_advertising_sync_established_after_cancel_command_error_test) {

  uint16_t sync_handle = 0x12;

  Address address;

  Address::FromString("00:11:22:33:44:55", address);