Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2c05c32d authored by Martin Geisler's avatar Martin Geisler
Browse files

Revert "pdl: Generate canonical tests with prettyplease"

Revert submission 2586907

Reason for revert: http://b/283107621

Reverted changes: /q/submissionid:2586907

Change-Id: I1f96ca5ab15a0378488cd2df86a3e435e751422c
parent 8dc122e0
Loading
Loading
Loading
Loading
+16 −5
Original line number Diff line number Diff line
@@ -245,7 +245,6 @@ rust_binary_host {
    name: "pdl_generate_tests",
    srcs: ["src/bin/generate-canonical-tests.rs"],
    rustlibs: [
        "libprettyplease",
        "libproc_macro2",
        "libquote",
        "libserde",
@@ -255,20 +254,32 @@ rust_binary_host {
    ],
}

genrule_defaults {
    name: "pdl_rust_generator_src_defaults",
    tools: [
        ":pdl_generate_tests",
        ":rustfmt",
    ],
}

genrule {
    name: "pdl_rust_generator_tests_le_src",
    cmd: "$(location :pdl_generate_tests) $(in) pdl_le_backend > $(out)",
    cmd: "set -o pipefail;" +
        " $(location :pdl_generate_tests) $(in) pdl_le_backend |" +
        " $(location :rustfmt) > $(out)",
    srcs: ["tests/canonical/le_test_vectors.json"],
    out: ["le_canonical.rs"],
    tools: [":pdl_generate_tests"],
    defaults: ["pdl_rust_generator_src_defaults"],
}

genrule {
    name: "pdl_rust_generator_tests_be_src",
    cmd: "$(location :pdl_generate_tests) $(in) pdl_be_backend > $(out)",
    cmd: "set -o pipefail;" +
        " $(location :pdl_generate_tests) $(in) pdl_be_backend |" +
        " $(location :rustfmt) > $(out)",
    srcs: ["tests/canonical/be_test_vectors.json"],
    out: ["be_canonical.rs"],
    tools: [":pdl_generate_tests"],
    defaults: ["pdl_rust_generator_src_defaults"],
}

rust_test_host {
+11 −10
Original line number Diff line number Diff line
@@ -128,16 +128,17 @@ fn generate_unit_tests(input: &str, packet_names: &[&str], module_name: &str) {
    }

    // TODO(mgeisler): make the generated code clean from warnings.
    let code = quote! {
        #![allow(warnings, missing_docs)]

    println!("#![allow(warnings, missing_docs)]");
    println!();
    println!(
        "{}",
        &quote! {
            use #module::Packet;
            use serde_json::json;

            #(#tests)*
    };
    let syntax_tree = syn::parse2::<syn::File>(code).expect("Could not parse {code:#?}");
    println!("{}", prettyplease::unparse(&syntax_tree));
        }
    );
}

fn main() {