Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 25f26f72 authored by Zach Johnson's avatar Zach Johnson
Browse files

Remove return type from l2c_link_hci_conn_comp 

It's not used.

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I1602876f9e3c147c8c86a205fc4821753b1d52e2
parent 56bd9ce2

system/stack/include/l2cap_hci_link_interface.h

+1 −1
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ extern bool l2c_link_hci_conn_req(const RawAddress& bd_addr); 


extern void l2c_link_process_num_completed_pkts(uint8_t* p, uint8_t evt_len);



extern bool l2c_link_hci_conn_comp(uint8_t status, uint16_t handle,

extern void l2c_link_hci_conn_comp(uint8_t status, uint16_t handle,

                                   const RawAddress& p_bda);



extern bool l2c_link_hci_disc_comp(uint16_t handle, uint8_t reason);

system/stack/l2cap/l2c_link.cc

+6 −6
Original line number Diff line number Diff line
@@ -140,7 +140,7 @@ bool l2c_link_hci_conn_req(const RawAddress& bd_addr) { 
 * Returns          void

 *

 ******************************************************************************/

bool l2c_link_hci_conn_comp(uint8_t status, uint16_t handle,

void l2c_link_hci_conn_comp(uint8_t status, uint16_t handle,

                            const RawAddress& p_bda) {

  tL2C_CONN_INFO ci;

  tL2C_LCB* p_lcb;
@@ -162,7 +162,7 @@ bool l2c_link_hci_conn_comp(uint8_t status, uint16_t handle, 
    p_lcb = l2cu_allocate_lcb(ci.bd_addr, false, BT_TRANSPORT_BR_EDR);

    if (p_lcb == nullptr) {

      L2CAP_TRACE_WARNING("%s: Failed to allocate an LCB", __func__);

      return (false);

      return;

    }

    p_lcb->link_state = LST_CONNECTING;

  }
@@ -171,14 +171,14 @@ bool l2c_link_hci_conn_comp(uint8_t status, uint16_t handle, 
      (status == HCI_ERR_CONNECTION_EXISTS)) {

    L2CAP_TRACE_WARNING("%s: An ACL connection already exists. Handle:%d",

                        __func__, handle);

    return (true);

    return;

  } else if (p_lcb->link_state != LST_CONNECTING) {

    L2CAP_TRACE_ERROR("L2CAP got conn_comp in bad state: %d  status: 0x%d",

                      p_lcb->link_state, status);



    if (status != HCI_SUCCESS) l2c_link_hci_disc_comp(p_lcb->handle, status);



    return (false);

    return;

  }



  /* Save the handle */
@@ -205,7 +205,7 @@ bool l2c_link_hci_conn_comp(uint8_t status, uint16_t handle, 


    /* If dedicated bonding do not process any further */

    if (p_lcb->is_bonding) {

      if (l2cu_start_post_bond_timer(handle)) return (true);

      if (l2cu_start_post_bond_timer(handle)) return;

    }



    /* Update the timeouts in the hold queue */
@@ -264,7 +264,7 @@ bool l2c_link_hci_conn_comp(uint8_t status, uint16_t handle, 
      }

    }

  }

  return (true);

  return;

}



/*******************************************************************************