Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 22f5e11b authored by Henri Chataing's avatar Henri Chataing
Browse files

Enforce -Wmissing-prototypes 

This lint check will raise an error if a function is implemented
without a corresponding prototype declaration included in scope.

The main use case will be to ensure mock functions do not become out of
sync causing the original function to be linked instead.

Because of the large amount of errors, this change suppresses
errors in all locations, to be cleaned up gradually.

Bug: 369381361
Test: m com.android.btservices
Flag: EXEMPT, lint fixes
Change-Id: I888b5e284e237d8a6e2864bdde55c0a7fc0c348d
parent d26f2419

Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -66,6 +66,7 @@ cc_defaults { 
        "-Wall",

        "-Werror",

        "-Wextra",

        "-Wmissing-prototypes",

        // Override global.go that demote the error to a warning

        "-Werror=format",

        "-Werror=reorder-init-list",

android/app/Android.bp

+2 −5
Original line number Diff line number Diff line
@@ -199,11 +199,8 @@ cc_library { 
        "libbluetooth-types",

    ],

    cflags: [

        /* we export all classes, so change default visibility, instead of having EXPORT_SYMBOL on each class*/

        "-Wall",

        "-Werror",

        "-Wextra",

        "-Wno-unused-parameter",

        // we export all classes, so change default visibility,

        // instead of having EXPORT_SYMBOL on each class

        "-fvisibility=default",

    ],

    sanitize: {

android/app/jni/com_android_bluetooth_avrcp_target.cpp

+3 −0
Original line number Diff line number Diff line
@@ -27,6 +27,9 @@ 


#include "./com_android_bluetooth.h"



// TODO(b/369381361) Enfore -Wmissing-prototypes

#pragma GCC diagnostic ignored "-Wmissing-prototypes"



using bluetooth::avrcp::Attribute;

using bluetooth::avrcp::AttributeEntry;

using bluetooth::avrcp::FolderInfo;

android/app/jni/com_android_bluetooth_btservice_AdapterService.cpp

+3 −0
Original line number Diff line number Diff line
@@ -33,6 +33,9 @@ 
#include "hardware/bt_sock.h"

#include "types/bt_transport.h"



// TODO(b/369381361) Enfore -Wmissing-prototypes

#pragma GCC diagnostic ignored "-Wmissing-prototypes"



using bluetooth::Uuid;

extern bt_interface_t bluetoothInterface;

android/app/jni/com_android_bluetooth_gatt.cpp

+3 −0
Original line number Diff line number Diff line
@@ -33,6 +33,9 @@ 
#include "rust/src/gatt/ffi/gatt_shim.h"

#include "src/gatt/ffi.rs.h"



// TODO(b/369381361) Enfore -Wmissing-prototypes

#pragma GCC diagnostic ignored "-Wmissing-prototypes"



using bluetooth::Uuid;



#define UUID_PARAMS(uuid) uuid_lsb(uuid), uuid_msb(uuid)