Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 226d1670 authored by Hansong Zhang's avatar Hansong Zhang
Browse files

advertise_data_parser: fix a potential OOB

Bug: 121036603
Test: POC
Change-Id: I56a5c5bdadec9dded5684caff20bd9cb001dca6c
parent 81ffe2b7
Loading
Loading
Loading
Loading
+2 −1
Original line number Diff line number Diff line
@@ -34,7 +34,8 @@ class AdvertiseDataParser {
    auto data_start = ad.begin() + position;

    // Traxxas - bad name length
    if (std::equal(data_start, data_start + 3, trx_quirk.begin()) &&
    if ((ad.size() - position) >= 18 &&
        std::equal(data_start, data_start + 3, trx_quirk.begin()) &&
        std::equal(data_start + 5, data_start + 11, trx_quirk.begin() + 5) &&
        std::equal(data_start + 12, data_start + 18, trx_quirk.begin() + 12)) {
      return true;