Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 22062116 authored by Cheney Ni's avatar Cheney Ni
Browse files

Ignore SDP failure while bonding if SDP was not attempted 

When bonding, there is an ACL_UP event to the upper layers and some apps
may want to fetch SDP in return. This can break pairing. In cases SDP fails,
it causes the procedure to be finished before the LinkKey is generated.
And thus the LinkKey is not committed to NVRAM and the device is not paired.

Bug: 111189110
Test: : Pair / Unpair BT accessories manually
Change-Id: Iaefbe8b6c1fc3e78f0f120220992df84699a2eb8
parent a9ea5aad

system/btif/src/btif_dm.cc

+9 −4
Original line number Diff line number Diff line
@@ -1397,10 +1397,15 @@ static void btif_dm_search_services_evt(uint16_t event, char* p_param) { 
      if ((p_data->disc_res.result != BTA_SUCCESS) &&

          (pairing_cb.state == BT_BOND_STATE_BONDING) &&

          (pairing_cb.sdp_attempts < BTIF_DM_MAX_SDP_ATTEMPTS_AFTER_PAIRING)) {

        if (pairing_cb.sdp_attempts) {

          BTIF_TRACE_WARNING("%s: SDP failed after bonding re-attempting",

                             __func__);

          pairing_cb.sdp_attempts++;

          btif_dm_get_remote_services(bd_addr);

        } else {

          BTIF_TRACE_WARNING("%s: SDP triggered by someone failed when bonding",

                             __func__);

        }

        return;

      }

      prop.type = BT_PROPERTY_UUIDS;