Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2162c5fe authored by Himanshu Rawat's avatar Himanshu Rawat
Browse files

Remove unused native hid host interface 

btif_hh_connect() is not used outside btif_hh.cc anymore. There is no
need to maintain a profile interface for it.

Flag: EXEMPT bugfix
Test: mmm packages/modules/Bluetooth
Bug: 347241319
Change-Id: I67e59658effb404ed035a0063d15185e1d750bbb
parent d74ea950

system/btif/include/btif_hh.h

+0 −1
Original line number Diff line number Diff line
@@ -149,7 +149,6 @@ extern btif_hh_cb_t btif_hh_cb; 
btif_hh_device_t* btif_hh_find_connected_dev_by_handle(uint8_t handle);

btif_hh_device_t* btif_hh_find_dev_by_handle(uint8_t handle);

btif_hh_device_t* btif_hh_find_empty_dev(void);

bt_status_t btif_hh_connect(const tAclLinkSpec& link_spec);

bt_status_t btif_hh_virtual_unplug(const tAclLinkSpec& link_spec);

void btif_hh_remove_device(const tAclLinkSpec& link_spec);

void btif_hh_setreport(btif_hh_uhid_t* p_uhid, bthh_report_type_t r_type, uint16_t size,

system/btif/include/core_callbacks.h

+0 −1
Original line number Diff line number Diff line
@@ -94,7 +94,6 @@ struct CodecInterface { 
// that profiles can register themselves to.

struct HACK_ProfileInterface {

  // HID hacks

  bt_status_t (*btif_hh_connect)(const tAclLinkSpec& link_spec);

  bt_status_t (*btif_hh_virtual_unplug)(const tAclLinkSpec& link_spec);

  tBTA_HH_STATUS (*bta_hh_read_ssr_param)(const tAclLinkSpec& link_spec, uint16_t* p_max_ssr_lat,

                                          uint16_t* p_min_ssr_tout);

system/btif/include/mock_core_callbacks.h

+0 −3
Original line number Diff line number Diff line
@@ -86,9 +86,6 @@ MockCodecInterface mock_codec_msbcCodec; 
MockCodecInterface mock_codec_lc3Codec;



HACK_ProfileInterface mock_HACK_profile_interface = {

        .btif_hh_connect = [](const tAclLinkSpec& /* link_spec */) -> bt_status_t {

          return BT_STATUS_SUCCESS;

        },

        .btif_hh_virtual_unplug = [](const tAclLinkSpec& /* link_spec */) -> bt_status_t {

          return BT_STATUS_SUCCESS;

        },

system/btif/src/bluetooth.cc

+0 −1
Original line number Diff line number Diff line
@@ -364,7 +364,6 @@ static bluetooth::core::CoreInterface* CreateInterfaceToProfiles() { 
  };

  static bluetooth::core::HACK_ProfileInterface profileInterface{

          // HID

          .btif_hh_connect = btif_hh_connect,

          .btif_hh_virtual_unplug = btif_hh_virtual_unplug,

          .bta_hh_read_ssr_param = bta_hh_read_ssr_param,

system/test/common/core_interface.cc

+0 −1
Original line number Diff line number Diff line
@@ -79,7 +79,6 @@ static auto mockLc3CodecInterface = MockLc3CodecInterface{}; 


struct bluetooth::core::HACK_ProfileInterface HACK_profileInterface = {

        // HID

        .btif_hh_connect = nullptr,

        .btif_hh_virtual_unplug = nullptr,

        .bta_hh_read_ssr_param = nullptr,