Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e806ab9 authored by Jakub Rotkiewicz's avatar Jakub Rotkiewicz
Browse files

SnoopLogger: Debug enhancements feature flag 

Bug: 247859568
Tag: #feature
Test: atest bluetooth_test_gd
BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines

Change-Id: I7fec2b0fccd64efe754fce9ad09a7096022a72df
parent bf2a0b20

system/gd/common/init_flags.fbs

+1 −0
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ table InitFlagsData { 
    gatt_robust_caching_client_is_enabled:bool (privacy:"Any");

    gatt_robust_caching_server_is_enabled:bool (privacy:"Any");

    gd_core_is_enabled:bool (privacy:"Any");

    gd_hal_snoop_logger_filtering_is_enabled:bool (privacy:"Any");

    gd_hal_snoop_logger_socket_is_enabled:bool (privacy:"Any");

    gd_l2cap_is_enabled:bool (privacy:"Any");

    gd_link_policy_is_enabled:bool (privacy:"Any");

system/gd/common/init_flags.h

+4 −0
Original line number Diff line number Diff line
@@ -56,6 +56,10 @@ class InitFlags final { 
    return init_flags::gd_hal_snoop_logger_socket_is_enabled();

  }



  inline static bool IsSnoopLoggerFilteringEnabled() {

    return init_flags::gd_hal_snoop_logger_filtering_is_enabled();

  }



  inline static bool IsTargetedAnnouncementReconnectionMode() {

    return init_flags::leaudio_targeted_announcement_reconnection_mode_is_enabled();

  }

system/gd/common/init_flags_test.cc

+6 −0
Original line number Diff line number Diff line
@@ -86,3 +86,9 @@ TEST(InitFlagsTest, test_device_iot_config_logging_is_enabled) { 
  InitFlags::Load(input);

  ASSERT_TRUE(InitFlags::IsDeviceIotConfigLoggingEnabled());

}



TEST(InitFlagsTest, test_enable_snoop_logger_filtering) {

  const char* input[] = {"INIT_gd_hal_snoop_logger_filtering=true", nullptr};

  InitFlags::Load(input);

  ASSERT_TRUE(InitFlags::IsSnoopLoggerFilteringEnabled());

}
 
 No newline at end of file

system/gd/dumpsys/init_flags.cc

+2 −0
Original line number Diff line number Diff line
@@ -43,6 +43,8 @@ flatbuffers::Offset<bluetooth::common::InitFlagsData> bluetooth::dumpsys::InitFl 
      initFlags::device_iot_config_logging_is_enabled());

  builder.add_dynamic_avrcp_version_enhancement_is_enabled(

      initFlags::dynamic_avrcp_version_enhancement_is_enabled());

  builder.add_gd_hal_snoop_logger_filtering_is_enabled(

      bluetooth::common::init_flags::gd_hal_snoop_logger_filtering_is_enabled());

  builder.add_finite_att_timeout_is_enabled(initFlags::finite_att_timeout_is_enabled());

  builder.add_gatt_robust_caching_client_is_enabled(initFlags::gatt_robust_caching_client_is_enabled());

  builder.add_gatt_robust_caching_server_is_enabled(initFlags::gatt_robust_caching_server_is_enabled());

system/gd/hal/snoop_logger.cc

+5 −0
Original line number Diff line number Diff line
@@ -504,6 +504,11 @@ SnoopLogger::SnoopLogger( 
      snoop_log_persists(snoop_log_persists) {

  btsnoop_mode_ = btsnoop_mode;



  if (btsnoop_mode_ == kBtSnoopLogModeFiltered &&

      !bluetooth::common::InitFlags::IsSnoopLoggerFilteringEnabled()) {

    btsnoop_mode_ = kBtSnoopLogModeDisabled;

  }



  if (btsnoop_mode_ == kBtSnoopLogModeFiltered) {

    LOG_INFO("Snoop Logs filtered mode enabled");

    EnableFilters();