Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 197cd749 authored by William Escande's avatar William Escande
Browse files

Revert "Wait for state callback before ending constructor" 

This reverts commit f1d39c38.

Reason: Creating crash on some early process and not really reducing
flakiness in intensive testing

Bug: 362049035
Bug: 357645528
Test: m Bluetooth
Flag: com.android.bluetooth.flags.broadcast_adapter_state_with_callback
Change-Id: I4e06a724ab52e5320a074411f8a4c2d5fe24e2e1
parent 220e5314

framework/java/android/bluetooth/BluetoothAdapter.java

+0 −33
Original line number Diff line number Diff line
@@ -96,12 +96,8 @@ import java.util.Map; 
import java.util.Set;

import java.util.UUID;

import java.util.WeakHashMap;

import java.util.concurrent.CompletableFuture;

import java.util.concurrent.ConcurrentHashMap;

import java.util.concurrent.ExecutionException;

import java.util.concurrent.Executor;

import java.util.concurrent.TimeUnit;

import java.util.concurrent.TimeoutException;

import java.util.concurrent.locks.ReentrantReadWriteLock;

import java.util.function.BiFunction;

import java.util.function.Consumer;
@@ -877,7 +873,6 @@ public final class BluetoothAdapter { 
    @GuardedBy("mServiceLock")

    private IBluetooth mService;



    private static CompletableFuture<Void> sAdapterStateFuture = null;

    private static int sAdapterState = BluetoothAdapter.STATE_OFF;



    private final ReentrantReadWriteLock mServiceLock = new ReentrantReadWriteLock();
@@ -1178,20 +1173,6 @@ public final class BluetoothAdapter { 
                new CallbackWrapper(

                        registerBluetoothConnectionCallbackConsumer,

                        unregisterBluetoothConnectionCallbackConsumer);



        if (!Flags.broadcastAdapterStateWithCallback()) {

            return;

        }

        // Make sure that we are waiting on the state callback prior to returning from constructor

        CompletableFuture<Void> futureState = sAdapterStateFuture;

        if (futureState != null) {

            try {

                futureState.get(1_000, TimeUnit.MILLISECONDS);

            } catch (InterruptedException | ExecutionException | TimeoutException e) {

                Log.e(TAG, e.toString() + "\n" + Log.getStackTraceString(new Throwable()));

            }

        }

        Log.i(TAG, "Adapter created with state: " + nameForState(sAdapterState));

    }



    /**
@@ -3803,12 +3784,6 @@ public final class BluetoothAdapter { 


                @RequiresNoPermission

                public void onBluetoothAdapterStateChange(int newState) {

                    Log.v(TAG, "onBluetoothAdapterStateChange(" + nameForState(newState) + ")");

                    CompletableFuture<Void> future = sAdapterStateFuture;

                    sAdapterStateFuture = null;

                    if (future != null) {

                        future.complete(null);

                    }

                    sAdapterState = newState;

                }

            };
@@ -4243,11 +4218,6 @@ public final class BluetoothAdapter { 
            return;

        }

        if (wantRegistered) {

            if (Flags.broadcastAdapterStateWithCallback()

                    && sAdapterState == BluetoothAdapter.STATE_OFF

                    && sAdapterStateFuture == null) {

                sAdapterStateFuture = new CompletableFuture<>();

            }

            try {

                sService =

                        IBluetooth.Stub.asInterface(
@@ -4262,9 +4232,6 @@ public final class BluetoothAdapter { 
            } catch (RemoteException e) {

                throw e.rethrowAsRuntimeException();

            }

            if (Flags.broadcastAdapterStateWithCallback()) {

                sAdapterState = BluetoothAdapter.STATE_OFF;

            }

        }

        sServiceRegistered = wantRegistered;

    }