Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1694d818 authored by William Escande's avatar William Escande
Browse files

ErrorProne: Enforce & fix UnnecessaryAssignment 

Bug: 344658662
Test: m BluetoothInstrumentationTests
Flag: Exempt Build and test only
Change-Id: Ibaecef125f34fd6414914298a99429fc1c78c691
parent b05d3d41

android/app/tests/unit/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -60,6 +60,7 @@ java_defaults { 
            "-Xep:AlmostJavadoc:ERROR",

            "-Xep:EmptyCatch:ERROR",

            "-Xep:InvalidInlineTag:ERROR",

            "-Xep:UnnecessaryAssignment:ERROR",

            "-Xep:UnnecessaryAsync:ERROR",

            "-Xep:UnusedMethod:ERROR",

        ],

android/app/tests/unit/src/com/android/bluetooth/sdp/DipTest.java

+1 −1
Original line number Diff line number Diff line
@@ -63,7 +63,7 @@ public class DipTest { 


    @Rule public MockitoRule mockitoRule = MockitoJUnit.rule();



    @Mock private AdapterService mAdapterService = null;

    @Mock private AdapterService mAdapterService;

    @Mock private SdpManagerNativeInterface mNativeInterface;



    @Before

android/app/tests/unit/src/com/android/bluetooth/telephony/BluetoothInCallServiceTest.java

+1 −1
Original line number Diff line number Diff line
@@ -107,7 +107,7 @@ public class BluetoothInCallServiceTest { 
    @Mock private BluetoothLeCallControlProxy mMockBluetoothLeCallControl;

    @Mock private BluetoothInCallService.CallInfo mMockCallInfo;

    @Mock private TelephonyManager mMockTelephonyManager;

    @Mock private Context mContext = ApplicationProvider.getApplicationContext();

    @Mock private Context mContext;



    public class TestableBluetoothInCallService extends BluetoothInCallService {

        @Override

framework/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -93,6 +93,7 @@ java_sdk_library { 


            "-Xep:EmptyCatch:ERROR",

            "-Xep:InvalidInlineTag:ERROR",

            "-Xep:UnnecessaryAssignment:ERROR",

            "-Xep:UnnecessaryAsync:ERROR",



            "-XepExcludedPaths:.*/srcjars/.*", // Exclude generated files

service/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -28,6 +28,7 @@ java_defaults { 
            "-Xep:EqualsIncompatibleType:ERROR",

            "-Xep:InvalidInlineTag:ERROR",

            "-Xep:ReferenceEquality:ERROR",

            "-Xep:UnnecessaryAssignment:ERROR",

            "-Xep:UnnecessaryAsync:ERROR",

            "-Xep:UnusedMethod:ERROR",

            "-Xep:UnusedVariable:ERROR",