Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 15681e44 authored by Pavlin Radoslavov's avatar Pavlin Radoslavov
Browse files

Allocate/free the SDP connection timers only during stack startup/shutdown 

This avoids freeing the sdp_conn_timer within the alarm callback itself.

Bug: 67110137
Test: Manual
Change-Id: I775b4b532cd42cf207258c53c6052a167a124627
Merged-In: I775b4b532cd42cf207258c53c6052a167a124627
(cherry picked from commit ef6a4a0c9d9220a7d909863349d7a0c0b967d54c)
parent 05c9d902

system/stack/btu/btu_init.c

+2 −0
Original line number Diff line number Diff line
@@ -115,6 +115,8 @@ void btu_free_core(void) 
      /* Free the mandatory core stack components */

      l2c_free();



      sdp_free();



#if BLE_INCLUDED == TRUE

      gatt_free();

#endif

system/stack/sdp/sdp_main.c

+11 −0
Original line number Diff line number Diff line
@@ -85,6 +85,10 @@ void sdp_init (void) 
    /* Clears all structures and local SDP database (if Server is enabled) */

    memset (&sdp_cb, 0, sizeof (tSDP_CB));



    for (int i = 0; i < SDP_MAX_CONNECTIONS; i++) {

      sdp_cb.ccb[i].sdp_conn_timer = alarm_new("sdp.sdp_conn_timer");

    }



    /* Initialize the L2CAP configuration. We only care about MTU and flush */

    sdp_cb.l2cap_my_cfg.mtu_present       = TRUE;

    sdp_cb.l2cap_my_cfg.mtu               = SDP_MTU_SIZE;
@@ -139,6 +143,13 @@ void sdp_init (void) 
    }

}



void sdp_free(void) {

  for (int i = 0; i < SDP_MAX_CONNECTIONS; i++) {

    alarm_free(sdp_cb.ccb[i].sdp_conn_timer);

    sdp_cb.ccb[i].sdp_conn_timer = NULL;

  }

}



#if (defined(SDP_DEBUG) && SDP_DEBUG == TRUE)

/*******************************************************************************

**

system/stack/sdp/sdp_utils.c

+3 −3
Original line number Diff line number Diff line
@@ -120,8 +120,9 @@ tCONN_CB *sdpu_allocate_ccb (void) 
    {

        if (p_ccb->con_state == SDP_STATE_IDLE)

        {

            alarm_t* alarm = p_ccb->sdp_conn_timer;

            memset(p_ccb, 0, sizeof(tCONN_CB));

            p_ccb->sdp_conn_timer = alarm_new("sdp.sdp_conn_timer");

            p_ccb->sdp_conn_timer = alarm;

            return (p_ccb);

        }

    }
@@ -143,8 +144,7 @@ tCONN_CB *sdpu_allocate_ccb (void) 
void sdpu_release_ccb (tCONN_CB *p_ccb)

{

    /* Ensure timer is stopped */

    alarm_free(p_ccb->sdp_conn_timer);

    p_ccb->sdp_conn_timer = NULL;

    alarm_cancel(p_ccb->sdp_conn_timer);



    /* Drop any response pointer we may be holding */

    p_ccb->con_state = SDP_STATE_IDLE;

system/stack/sdp/sdpint.h

+1 −0
Original line number Diff line number Diff line
@@ -246,6 +246,7 @@ extern tSDP_CB *sdp_cb_ptr; 


/* Functions provided by sdp_main.c */

extern void     sdp_init (void);

extern void     sdp_free(void);

extern void     sdp_disconnect (tCONN_CB*p_ccb, UINT16 reason);



#if (defined(SDP_DEBUG) && SDP_DEBUG == TRUE)