Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c09b127 authored by Hyundo Moon's avatar Hyundo Moon Committed by Automerger Merge Worker
Browse files

Merge "Add more BluetoothPbapObexServer tests" am: b8197244 am: 2bd48097 

Original change: https://android-review.googlesource.com/c/platform/packages/modules/Bluetooth/+/2309212



Change-Id: I39643732addf23413cc200ff3c59d93e0e2f3e26
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents 3bf960ff 2bd48097

android/app/src/com/android/bluetooth/pbap/BluetoothPbapObexServer.java

+19 −10
Original line number Diff line number Diff line
@@ -696,7 +696,8 @@ public class BluetoothPbapObexServer extends ServerRequestHandler { 
    }



    /** To parse obex application parameter */

    private boolean parseApplicationParameter(final byte[] appParam, AppParamValue appParamValue) {

    @VisibleForTesting

    boolean parseApplicationParameter(final byte[] appParam, AppParamValue appParamValue) {

        int i = 0;

        boolean parseOk = true;

        while ((i < appParam.length) && (parseOk)) {
@@ -974,7 +975,8 @@ public class BluetoothPbapObexServer extends ServerRequestHandler { 
     * Function to send obex header back to client such as get phonebook size

     * request

     */

    private int pushHeader(final Operation op, final HeaderSet reply) {

    @VisibleForTesting

    static int pushHeader(final Operation op, final HeaderSet reply) {

        OutputStream outputStream = null;



        if (D) {
@@ -1495,7 +1497,7 @@ public class BluetoothPbapObexServer extends ServerRequestHandler { 
    /**

     * XML encode special characters in the name field

     */

    private void xmlEncode(String name, StringBuilder result) {

    private static void xmlEncode(String name, StringBuilder result) {

        if (name == null) {

            return;

        }
@@ -1521,7 +1523,8 @@ public class BluetoothPbapObexServer extends ServerRequestHandler { 
        }

    }



    private void writeVCardEntry(int vcfIndex, String name, StringBuilder result) {

    @VisibleForTesting

    static void writeVCardEntry(int vcfIndex, String name, StringBuilder result) {

        result.append("<card handle=\"");

        result.append(vcfIndex);

        result.append(".vcf\" name=\"");
@@ -1556,13 +1559,15 @@ public class BluetoothPbapObexServer extends ServerRequestHandler { 
        }

    }



    private void setDbCounters(ApplicationParameter ap) {

    @VisibleForTesting

    void setDbCounters(ApplicationParameter ap) {

        ap.addTriplet(ApplicationParameter.TRIPLET_TAGID.DATABASEIDENTIFIER_TAGID,

                ApplicationParameter.TRIPLET_LENGTH.DATABASEIDENTIFIER_LENGTH,

                getDatabaseIdentifier());

    }



    private void setFolderVersionCounters(ApplicationParameter ap) {

    @VisibleForTesting

    static void setFolderVersionCounters(ApplicationParameter ap) {

        ap.addTriplet(ApplicationParameter.TRIPLET_TAGID.PRIMARYVERSIONCOUNTER_TAGID,

                ApplicationParameter.TRIPLET_LENGTH.PRIMARYVERSIONCOUNTER_LENGTH,

                getPBPrimaryFolderVersion());
@@ -1571,7 +1576,8 @@ public class BluetoothPbapObexServer extends ServerRequestHandler { 
                getPBSecondaryFolderVersion());

    }



    private void setCallversionCounters(ApplicationParameter ap, AppParamValue appParamValue) {

    @VisibleForTesting

    static void setCallversionCounters(ApplicationParameter ap, AppParamValue appParamValue) {

        ap.addTriplet(ApplicationParameter.TRIPLET_TAGID.PRIMARYVERSIONCOUNTER_TAGID,

                ApplicationParameter.TRIPLET_LENGTH.PRIMARYVERSIONCOUNTER_LENGTH,

                appParamValue.callHistoryVersionCounter);
@@ -1581,7 +1587,8 @@ public class BluetoothPbapObexServer extends ServerRequestHandler { 
                appParamValue.callHistoryVersionCounter);

    }



    private byte[] getDatabaseIdentifier() {

    @VisibleForTesting

    byte[] getDatabaseIdentifier() {

        mDatabaseIdentifierHigh = 0;

        mDatabaseIdentifierLow = BluetoothPbapUtils.sDbIdentifier.get();

        if (mDatabaseIdentifierLow != INVALID_VALUE_PARAMETER
@@ -1595,7 +1602,8 @@ public class BluetoothPbapObexServer extends ServerRequestHandler { 
        }

    }



    private byte[] getPBPrimaryFolderVersion() {

    @VisibleForTesting

    static byte[] getPBPrimaryFolderVersion() {

        long primaryVcMsb = 0;

        ByteBuffer pvc = ByteBuffer.allocate(16);

        pvc.putLong(primaryVcMsb);
@@ -1605,7 +1613,8 @@ public class BluetoothPbapObexServer extends ServerRequestHandler { 
        return pvc.array();

    }



    private byte[] getPBSecondaryFolderVersion() {

    @VisibleForTesting

    static byte[] getPBSecondaryFolderVersion() {

        long secondaryVcMsb = 0;

        ByteBuffer svc = ByteBuffer.allocate(16);

        svc.putLong(secondaryVcMsb);

android/app/tests/unit/src/com/android/bluetooth/pbap/BluetoothPbapObexServerTest.java

+260 −3
Original line number Diff line number Diff line
@@ -16,12 +16,36 @@ 


package com.android.bluetooth.pbap;



import static com.android.obex.ApplicationParameter.TRIPLET_LENGTH.FORMAT_LENGTH;

import static com.android.obex.ApplicationParameter.TRIPLET_LENGTH.LISTSTARTOFFSET_LENGTH;

import static com.android.obex.ApplicationParameter.TRIPLET_LENGTH.ORDER_LENGTH;

import static com.android.obex.ApplicationParameter.TRIPLET_LENGTH.PRIMARYVERSIONCOUNTER_LENGTH;

import static com.android.obex.ApplicationParameter.TRIPLET_LENGTH.PROPERTY_SELECTOR_LENGTH;

import static com.android.obex.ApplicationParameter.TRIPLET_LENGTH.SEARCH_ATTRIBUTE_LENGTH;

import static com.android.obex.ApplicationParameter.TRIPLET_LENGTH.SECONDARYVERSIONCOUNTER_LENGTH;

import static com.android.obex.ApplicationParameter.TRIPLET_LENGTH.SUPPORTEDFEATURE_LENGTH;

import static com.android.obex.ApplicationParameter.TRIPLET_LENGTH.VCARDSELECTOROPERATOR_LENGTH;

import static com.android.obex.ApplicationParameter.TRIPLET_LENGTH.VCARDSELECTOR_LENGTH;

import static com.android.obex.ApplicationParameter.TRIPLET_TAGID.FORMAT_TAGID;

import static com.android.obex.ApplicationParameter.TRIPLET_TAGID.LISTSTARTOFFSET_TAGID;

import static com.android.obex.ApplicationParameter.TRIPLET_TAGID.MAXLISTCOUNT_TAGID;

import static com.android.obex.ApplicationParameter.TRIPLET_TAGID.ORDER_TAGID;

import static com.android.obex.ApplicationParameter.TRIPLET_TAGID.PRIMARYVERSIONCOUNTER_TAGID;

import static com.android.obex.ApplicationParameter.TRIPLET_TAGID.PROPERTY_SELECTOR_TAGID;

import static com.android.obex.ApplicationParameter.TRIPLET_TAGID.SEARCH_ATTRIBUTE_TAGID;

import static com.android.obex.ApplicationParameter.TRIPLET_TAGID.SEARCH_VALUE_TAGID;

import static com.android.obex.ApplicationParameter.TRIPLET_TAGID.SECONDARYVERSIONCOUNTER_TAGID;

import static com.android.obex.ApplicationParameter.TRIPLET_TAGID.SUPPORTEDFEATURE_TAGID;

import static com.android.obex.ApplicationParameter.TRIPLET_TAGID.VCARDSELECTOROPERATOR_TAGID;

import static com.android.obex.ApplicationParameter.TRIPLET_TAGID.VCARDSELECTOR_TAGID;

import static com.android.obex.ApplicationParameter.TRIPLET_VALUE.ORDER.ORDER_BY_ALPHANUMERIC;



import static com.google.common.truth.Truth.assertThat;

import static com.google.common.truth.Truth.assertWithMessage;



import static org.mockito.Mockito.any;

import static org.mockito.Mockito.doThrow;

import static org.mockito.Mockito.doReturn;

import static org.mockito.Mockito.doThrow;

import static org.mockito.Mockito.eq;

import static org.mockito.Mockito.mock;

import static org.mockito.Mockito.verify;
@@ -35,6 +59,8 @@ import androidx.test.filters.SmallTest; 
import androidx.test.runner.AndroidJUnit4;



import com.android.bluetooth.BluetoothMethodProxy;

import com.android.bluetooth.pbap.BluetoothPbapObexServer.AppParamValue;

import com.android.obex.ApplicationParameter;

import com.android.obex.HeaderSet;

import com.android.obex.Operation;

import com.android.obex.ResponseCodes;
@@ -47,8 +73,6 @@ import org.mockito.Mock; 
import org.mockito.MockitoAnnotations;

import org.mockito.Spy;



import com.android.bluetooth.pbap.BluetoothPbapObexServer.AppParamValue;



import java.io.IOException;

import java.io.OutputStream;
@@ -590,4 +614,237 @@ public class BluetoothPbapObexServerTest { 
        assertThat(mServer.onGet(operation)).isEqualTo(ResponseCodes.OBEX_HTTP_OK);

    }



    @Test

    public void writeVCardEntry() {

        int vcfIndex = 1;

        String nameWithSpecialChars = "Name<>\"\'&";

        StringBuilder stringBuilder = new StringBuilder();



        BluetoothPbapObexServer.writeVCardEntry(vcfIndex, nameWithSpecialChars, stringBuilder);

        String result = stringBuilder.toString();



        String expectedResult = "<card handle=\"" + vcfIndex + ".vcf\" name=\"" +

                "Name&lt;&gt;&quot;&#039;&amp;" + "\"/>";

        assertThat(result).isEqualTo(expectedResult);

    }



    @Test

    public void getDatabaseIdentifier() {

        long databaseIdentifierLow = 1;

        BluetoothPbapUtils.sDbIdentifier.set(databaseIdentifierLow);

        byte[] expected = new byte[] {0, 0, 0, 0, 0, 0, 0, 0,

                0, 0, 0, 0, 0, 0, 0, 1}; // Big-endian



        assertThat(mServer.getDatabaseIdentifier()).isEqualTo(expected);

    }



    @Test

    public void getPBPrimaryFolderVersion() {

        long primaryVersion = 5;

        BluetoothPbapUtils.sPrimaryVersionCounter = primaryVersion;

        byte[] expected = new byte[] {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,

                0, 0, 0, 5}; // Big-endian



        assertThat(BluetoothPbapObexServer.getPBPrimaryFolderVersion()).isEqualTo(expected);

    }



    @Test

    public void getPBSecondaryFolderVersion() {

        long secondaryVersion = 5;

        BluetoothPbapUtils.sSecondaryVersionCounter = secondaryVersion;

        byte[] expected = new byte[] {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,

                0, 0, 0, 5}; // Big-endian



        assertThat(BluetoothPbapObexServer.getPBSecondaryFolderVersion()).isEqualTo(expected);

    }



    @Test

    public void setDbCounters() {

        ApplicationParameter param = new ApplicationParameter();



        mServer.setDbCounters(param);



        byte[] result = param.getHeader();

        assertThat(result).isNotNull();

        int expectedLength = 2 + ApplicationParameter.TRIPLET_LENGTH.DATABASEIDENTIFIER_LENGTH;

        assertThat(result.length).isEqualTo(expectedLength);

    }



    @Test

    public void setFolderVersionCounters() {

        ApplicationParameter param = new ApplicationParameter();



        BluetoothPbapObexServer.setFolderVersionCounters(param);



        byte[] result = param.getHeader();

        assertThat(result).isNotNull();

        int expectedLength = 2 + ApplicationParameter.TRIPLET_LENGTH.PRIMARYVERSIONCOUNTER_LENGTH

                + 2 + ApplicationParameter.TRIPLET_LENGTH.SECONDARYVERSIONCOUNTER_LENGTH;

        assertThat(result.length).isEqualTo(expectedLength);

    }



    @Test

    public void setCallversionCounters() {

        ApplicationParameter param = new ApplicationParameter();

        AppParamValue value = new AppParamValue();

        value.callHistoryVersionCounter = new byte[]

                {1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16};



        BluetoothPbapObexServer.setCallversionCounters(param, value);



        byte[] expectedResult = new byte[] {

                PRIMARYVERSIONCOUNTER_TAGID, PRIMARYVERSIONCOUNTER_LENGTH,

                1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16,

                SECONDARYVERSIONCOUNTER_TAGID, SECONDARYVERSIONCOUNTER_LENGTH,

                1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16

        };

        assertThat(param.getHeader()).isEqualTo(expectedResult);

    }



    @Test

    public void pushHeader_returnsObexHttpOk() throws Exception {

        Operation op = mock(Operation.class);

        OutputStream os = mock(OutputStream.class);

        when(op.openOutputStream()).thenReturn(os);

        HeaderSet reply = new HeaderSet();



        assertThat(BluetoothPbapObexServer.pushHeader(op, reply))

                .isEqualTo(ResponseCodes.OBEX_HTTP_OK);

    }



    @Test

    public void pushHeader_withExceptionWhenOpeningOutputStream_returnsObexHttpInternalError()

            throws Exception {

        HeaderSet reply = new HeaderSet();

        Operation op = mock(Operation.class);

        when(op.openOutputStream()).thenThrow(new IOException());



        assertThat(BluetoothPbapObexServer.pushHeader(op, reply))

                .isEqualTo(ResponseCodes.OBEX_HTTP_INTERNAL_ERROR);

    }



    @Test

    public void pushHeader_withExceptionWhenClosingOutputStream_returnsObexHttpInternalError()

            throws Exception {

        HeaderSet reply = new HeaderSet();

        Operation op = mock(Operation.class);

        OutputStream os = mock(OutputStream.class);

        when(op.openOutputStream()).thenReturn(os);

        doThrow(new IOException()).when(os).close();



        assertThat(BluetoothPbapObexServer.pushHeader(op, reply))

                .isEqualTo(ResponseCodes.OBEX_HTTP_INTERNAL_ERROR);

    }



    @Test

    public void parseApplicationParameter_withInvalidTripletTagid_returnsFalse() {

        byte invalidTripletTagId = 0x00;

        byte[] rawBytes = new byte[] {invalidTripletTagId};

        AppParamValue appParamValue = new AppParamValue();



        assertThat(mServer.parseApplicationParameter(rawBytes, appParamValue)).isFalse();

    }



    @Test

    public void parseApplicationParameter_withPropertySelectorTagid() {

        byte[] rawBytes = new byte[] {PROPERTY_SELECTOR_TAGID, PROPERTY_SELECTOR_LENGTH,

                0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08}; // non-zero value uses filter

        AppParamValue appParamValue = new AppParamValue();



        assertThat(mServer.parseApplicationParameter(rawBytes, appParamValue)).isTrue();

        assertThat(appParamValue.ignorefilter).isFalse();

    }



    @Test

    public void parseApplicationParameter_withSupportedFeatureTagid() {

        byte[] rawBytes = new byte[] {SUPPORTEDFEATURE_TAGID, SUPPORTEDFEATURE_LENGTH,

                0x01, 0x02, 0x03, 0x04};

        AppParamValue appParamValue = new AppParamValue();



        assertThat(mServer.parseApplicationParameter(rawBytes, appParamValue)).isTrue();

        byte[] expectedSupportedFeature = new byte[] {0x01, 0x02, 0x03, 0x04};

        assertThat(appParamValue.supportedFeature).isEqualTo(expectedSupportedFeature);

    }



    @Test

    public void parseApplicationParameter_withOrderTagid() {

        byte[] rawBytes = new byte[] {ORDER_TAGID, ORDER_LENGTH,

                ORDER_BY_ALPHANUMERIC};

        AppParamValue appParamValue = new AppParamValue();



        assertThat(mServer.parseApplicationParameter(rawBytes, appParamValue)).isTrue();

        assertThat(appParamValue.order).isEqualTo("1");

    }



    @Test

    public void parseApplicationParameter_withSearchValueTagid() {

        int searchLength = 4;

        byte[] rawBytes = new byte[] {SEARCH_VALUE_TAGID, (byte) searchLength,

                'a', 'b', 'c', 'd' };

        AppParamValue appParamValue = new AppParamValue();



        assertThat(mServer.parseApplicationParameter(rawBytes, appParamValue)).isTrue();

        assertThat(appParamValue.searchValue).isEqualTo("abcd");

    }



    @Test

    public void parseApplicationParameter_withSearchAttributeTagid() {

        byte[] rawBytes = new byte[] {SEARCH_ATTRIBUTE_TAGID, SEARCH_ATTRIBUTE_LENGTH,

                0x05};

        AppParamValue appParamValue = new AppParamValue();



        assertThat(mServer.parseApplicationParameter(rawBytes, appParamValue)).isTrue();

        assertThat(appParamValue.searchAttr).isEqualTo("5");

    }



    @Test

    public void parseApplicationParameter_withMaxListCountTagid() {

        byte[] rawBytes = new byte[] {MAXLISTCOUNT_TAGID, SEARCH_ATTRIBUTE_LENGTH,

                0x01, 0x02};

        AppParamValue appParamValue = new AppParamValue();



        assertThat(mServer.parseApplicationParameter(rawBytes, appParamValue)).isTrue();

        assertThat(appParamValue.maxListCount).isEqualTo(256 * 1 + 2);

    }



    @Test

    public void parseApplicationParameter_withListStartOffsetTagid() {

        byte[] rawBytes = new byte[] {LISTSTARTOFFSET_TAGID, LISTSTARTOFFSET_LENGTH,

                0x01, 0x02};

        AppParamValue appParamValue = new AppParamValue();



        assertThat(mServer.parseApplicationParameter(rawBytes, appParamValue)).isTrue();

        assertThat(appParamValue.listStartOffset).isEqualTo(256 * 1 + 2);

    }



    @Test

    public void parseApplicationParameter_withFormatTagid() {

        byte[] rawBytes = new byte[] {FORMAT_TAGID, FORMAT_LENGTH,

                0x01};

        AppParamValue appParamValue = new AppParamValue();



        assertThat(mServer.parseApplicationParameter(rawBytes, appParamValue)).isTrue();

        assertThat(appParamValue.vcard21).isFalse();

    }



    @Test

    public void parseApplicationParameter_withVCardSelectorTagid() {

        byte[] rawBytes = new byte[] {VCARDSELECTOR_TAGID, VCARDSELECTOR_LENGTH,

                0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08};

        AppParamValue appParamValue = new AppParamValue();



        assertThat(mServer.parseApplicationParameter(rawBytes, appParamValue)).isTrue();

        byte[] expectedVcardSelector = new byte[] {0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08};

        assertThat(appParamValue.vCardSelector).isEqualTo(expectedVcardSelector);

    }



    @Test

    public void parseApplicationParameter_withVCardSelectorOperatorTagid() {

        byte[] rawBytes = new byte[] {VCARDSELECTOROPERATOR_TAGID, VCARDSELECTOROPERATOR_LENGTH,

                0x01};

        AppParamValue appParamValue = new AppParamValue();



        assertThat(mServer.parseApplicationParameter(rawBytes, appParamValue)).isTrue();

        assertThat(appParamValue.vCardSelectorOperator).isEqualTo("1");

    }

}