Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07e0de91 authored by Pavlin Radoslavov's avatar Pavlin Radoslavov Committed by Android Git Automerger
Browse files

am cffc31f4: Check the return value when reading HCI type byte 

* commit 'cffc31f4':
  Check the return value when reading HCI type byte
parents d3892eac cffc31f4

system/hci/src/hci_hal_h4.c

+5 −2
Original line number Diff line number Diff line
@@ -174,9 +174,12 @@ static void event_uart_has_bytes(eager_reader_t *reader, UNUSED_ATTR void *conte 
    callbacks->data_ready(current_data_type);

  } else {

    uint8_t type_byte;

    eager_reader_read(reader, &type_byte, 1, true);

    if (eager_reader_read(reader, &type_byte, 1, true) == 0) {

      LOG_ERROR("%s could not read HCI message type", __func__);

      return;

    }

    if (type_byte < DATA_TYPE_ACL || type_byte > DATA_TYPE_EVENT) {

      LOG_ERROR("[h4] Unknown HCI message type. Dropping this byte 0x%x, min %x, max %x", type_byte, DATA_TYPE_ACL, DATA_TYPE_EVENT);

      LOG_ERROR("%s Unknown HCI message type. Dropping this byte 0x%x, min %x, max %x", __func__, type_byte, DATA_TYPE_ACL, DATA_TYPE_EVENT);

      return;

    }