Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07c97a31 authored by Henri Chataing's avatar Henri Chataing
Browse files

RootCanal: Set the default value of acl_data_packet_length to 1023 

BlueZ sets HCI_MAX_FRAME_SIZE to 1028 (1024 + 4) for the user socket.
In practice the length check counts the IDC towards the packet length
and the actual limit is 1023 bytes for the ACL payload.

Bug: 326997427
Bug: 356867879
Test: m com.android.btservices
Flag: EXEMPT, tool change
Change-Id: If197a39864a5eda27131aa2f7c58e706ecc4e9dd
parent 6d30a2c4

tools/rootcanal/model/controller/controller_properties.h

+3 −1
Original line number Original line Diff line number Diff line
@@ -112,7 +112,9 @@ public: 
  uint64_t le_features{0};

  uint64_t le_features{0};





  // Buffer Size (Vol 4, Part E § 7.4.5).

  // Buffer Size (Vol 4, Part E § 7.4.5).

  uint16_t acl_data_packet_length{1024};

  // Note: The blueZ HCI user socket limits the ACL Data Packet length to 1023

  // bytes (see HCI_MAX_FRAME_SIZE).

  uint16_t acl_data_packet_length{1023};

  uint8_t sco_data_packet_length{255};

  uint8_t sco_data_packet_length{255};

  uint16_t total_num_acl_data_packets{10};

  uint16_t total_num_acl_data_packets{10};

  uint16_t total_num_sco_data_packets{10};

  uint16_t total_num_sco_data_packets{10};