Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07319bbc authored by Yun-Hao Chung's avatar Yun-Hao Chung
Browse files

Floss: Fix invalid handle detection in SCO connection complete hack 

In pdl, the connection complete view only extracts 12 bits for the
connection handle, so even though some controller reports invalid handle
as 0xffff, the extracted value would be 0xfff.

This CL fixes the hack accordingly.

Bug: 294497459
Test: mma -j32
Test: build on ChromeOS
Tag: #floss
Change-Id: Ie0f56d51266ca80d8931203b766b734428fdf97a
parent ac9bc7b5

system/gd/hci/acl_manager/classic_impl.h

+4 −2
Original line number Diff line number Diff line
@@ -406,8 +406,10 @@ struct classic_impl : public security::ISecurityManagerListener { 


    // HACK: Some failed SCO connections are reporting failures via

    //       ConnectComplete instead of ScoConnectionComplete.

    //       Drop such packets.

    if (handle == 0xffff && link_type == LinkType::SCO) {

    //       The pattern of it is that the handle is always 0xffff.

    //       We check it with 0x0fff since PDL only extracts 12 bits for handle.

    //       Drop such packets when the pattern is matched.

    if (handle == 0x0fff && link_type == LinkType::SCO) {

      LOG_ERROR(

          "ConnectionComplete with invalid handle(%u), link type(%u) and status(%d). Dropping packet.",

          handle,