Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 04857bff authored by Jakub Tyszkowski's avatar Jakub Tyszkowski
Browse files

LeAudio: Remove redundant context type 

This member variable was set by the state machine
but read only in the unit tests which still work without
it. Therefore it is redundant.

Test: atest --host bluetooth_le_audio_test bluetooth_le_audio_client_test bluetooth_test_broadcaster --no-bazel-mode
Change-Id: Ibed8531d2692bb5eb834177f8b9ceb83aabf0dfa
parent f1790e9c

system/bta/le_audio/devices.cc

+0 −18
Original line number Diff line number Diff line
@@ -396,17 +396,6 @@ LeAudioDevice* LeAudioDeviceGroup::GetNextActiveDeviceByDataPathState( 
  return iter->lock().get();

}



bool LeAudioDeviceGroup::SetContextType(LeAudioContextType context_type) {

  /* XXX: group context policy ? / may it disallow to change type ?) */

  context_type_ = context_type;



  return true;

}



LeAudioContextType LeAudioDeviceGroup::GetContextType(void) {

  return context_type_;

}



uint32_t LeAudioDeviceGroup::GetSduInterval(uint8_t direction) {

  for (LeAudioDevice* leAudioDevice = GetFirstActiveDevice();

       leAudioDevice != nullptr;
@@ -1565,9 +1554,6 @@ const set_configurations::AudioSetConfiguration* 
LeAudioDeviceGroup::GetActiveConfiguration(void) {

  return active_context_to_configuration_map[active_context_type_];

}

AudioContexts LeAudioDeviceGroup::GetActiveContexts(void) {

  return active_contexts_mask_;

}



std::optional<LeAudioCodecConfiguration>

LeAudioDeviceGroup::GetCodecConfigurationByDirection(
@@ -1763,10 +1749,6 @@ void LeAudioDeviceGroup::CreateStreamVectorForOffloader(uint8_t direction) { 
  }

}



types::LeAudioContextType LeAudioDeviceGroup::GetCurrentContextType(void) {

  return active_context_type_;

}



bool LeAudioDeviceGroup::IsPendingConfiguration(void) {

  return stream_conf.pending_configuration;

}

system/bta/le_audio/devices.h

+11 −7
Original line number Diff line number Diff line
@@ -212,10 +212,10 @@ class LeAudioDeviceGroup { 
        transport_latency_stom_us_(0),

        active_context_type_(types::LeAudioContextType::UNINITIALIZED),

        metadata_context_type_(0),

        active_contexts_mask_(0),

        pending_update_available_contexts_(std::nullopt),

        target_state_(types::AseState::BTA_LE_AUDIO_ASE_STATE_IDLE),

        current_state_(types::AseState::BTA_LE_AUDIO_ASE_STATE_IDLE),

        context_type_(types::LeAudioContextType::UNINITIALIZED) {}

        current_state_(types::AseState::BTA_LE_AUDIO_ASE_STATE_IDLE) {}

  ~LeAudioDeviceGroup(void);



  void AddNode(const std::shared_ptr<LeAudioDevice>& leAudioDevice);
@@ -261,8 +261,6 @@ class LeAudioDeviceGroup { 
  bool Configure(types::LeAudioContextType context_type,

                 types::AudioContexts metadata_context_type,

                 std::vector<uint8_t> ccid_list = {});

  bool SetContextType(types::LeAudioContextType context_type);

  types::LeAudioContextType GetContextType(void);

  uint32_t GetSduInterval(uint8_t direction);

  uint8_t GetSCA(void);

  uint8_t GetPacking(void);
@@ -282,13 +280,11 @@ class LeAudioDeviceGroup { 
  bool ReloadAudioLocations(void);

  bool ReloadAudioDirections(void);

  const set_configurations::AudioSetConfiguration* GetActiveConfiguration(void);

  types::LeAudioContextType GetCurrentContextType(void);

  bool IsPendingConfiguration(void);

  void SetPendingConfiguration(void);

  bool IsConfigurationSupported(

      LeAudioDevice* leAudioDevice,

      const set_configurations::AudioSetConfiguration* audio_set_conf);

  types::AudioContexts GetActiveContexts(void);

  std::optional<LeAudioCodecConfiguration> GetCodecConfigurationByDirection(

      types::LeAudioContextType group_context_type, uint8_t direction);

  bool IsContextSupported(types::LeAudioContextType group_context_type);
@@ -320,10 +316,18 @@ class LeAudioDeviceGroup { 
    pending_update_available_contexts_ = audio_contexts;

  }



  inline types::LeAudioContextType GetCurrentContextType(void) const {

    return active_context_type_;

  }



  inline types::AudioContexts GetMetadataContextType(void) const {

    return metadata_context_type_;

  }



  inline types::AudioContexts GetActiveContexts(void) {

    return active_contexts_mask_;

  }



  bool IsInTransition(void);

  bool IsReleasing(void);

  void Dump(int fd);
@@ -348,6 +352,7 @@ class LeAudioDeviceGroup { 
  types::LeAudioContextType active_context_type_;

  types::AudioContexts metadata_context_type_;

  types::AudioContexts active_contexts_mask_;



  std::optional<types::AudioContexts> pending_update_available_contexts_;

  std::map<types::LeAudioContextType,

           const set_configurations::AudioSetConfiguration*>
@@ -355,7 +360,6 @@ class LeAudioDeviceGroup { 


  types::AseState target_state_;

  types::AseState current_state_;

  types::LeAudioContextType context_type_;

  std::vector<std::weak_ptr<LeAudioDevice>> leAudioDevices_;

};

system/bta/le_audio/le_audio_client_test.cc

+3 −12
Original line number Diff line number Diff line
@@ -671,8 +671,9 @@ class UnicastTestNoInit : public Test { 
            return false;

          }



          group->Configure(group->GetContextType(),

                           static_cast<uint16_t>(group->GetContextType()), {});

          group->Configure(

              group->GetCurrentContextType(),

              static_cast<uint16_t>(group->GetCurrentContextType()), {});

          if (!group->CigAssignCisIds(leAudioDevice)) return false;

          group->CigAssignCisConnHandlesToAses(leAudioDevice);
@@ -755,15 +756,6 @@ class UnicastTestNoInit : public Test { 
                              types::LeAudioContextType context_type,

                              types::AudioContexts metadata_context_type,

                              std::vector<uint8_t> ccid_list) {

          if (group->GetState() ==

              types::AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING) {

            if (group->GetContextType() != context_type) {

              /* TODO: Switch context of group */

              group->SetContextType(context_type);

            }

            return true;

          }



          /* Do what ReleaseCisIds(group) does: start */

          LeAudioDevice* leAudioDevice = group->GetFirstDevice();

          while (leAudioDevice != nullptr) {
@@ -784,7 +776,6 @@ class UnicastTestNoInit : public Test { 
          if (group->GetState() ==

              types::AseState::BTA_LE_AUDIO_ASE_STATE_IDLE) {

            group->CigGenerateCisIds(context_type);

            group->SetContextType(context_type);



            std::vector<uint16_t> conn_handles;

            for (uint8_t i = 0; i < (uint8_t)(group->cises_.size()); i++) {

system/bta/le_audio/state_machine.cc

+0 −1
Original line number Diff line number Diff line
@@ -192,7 +192,6 @@ class LeAudioGroupStateMachineImpl : public LeAudioGroupStateMachine { 
        }



        group->CigGenerateCisIds(context_type);

        group->SetContextType(context_type);

        /* All ASEs should aim to achieve target state */

        SetTargetState(group, AseState::BTA_LE_AUDIO_ASE_STATE_STREAMING);

        PrepareAndSendCodecConfigure(group, group->GetFirstActiveDevice());