Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0388ad1f authored by Chris Wailes's avatar Chris Wailes
Browse files

Remove a misleading "flush" function. 

This patch removes LocalSocketImpl.flush().  In practice this function
was simply a wrapper around `Thread.sleep(10)`.  All direct calls to
this function have been removed.  The `flush()` function is still called
on several objects that wrap a SocketOutputStream.

This will make booting a device 20ms faster than it currently is.

Bug: 139192244
Test: Build -> flash -> boot -> launch app
Change-Id: I0a96f4bc72461670370f61e847349f32af5ac774
parent ed6755fa

framework/java/android/bluetooth/BluetoothOutputStream.java

+0 −12
Original line number Diff line number Diff line
@@ -75,16 +75,4 @@ import java.io.OutputStream; 
        }

        mSocket.write(b, offset, count);

    }



    /**

     * Wait until the data in sending queue is emptied. A polling version

     * for flush implementation. Use it to ensure the writing data afterwards will

     * be packed in the new RFCOMM frame.

     *

     * @throws IOException if an i/o error occurs.

     * @since Android 4.2.3

     */

    public void flush() throws IOException {

        mSocket.flush();

    }

}

framework/java/android/bluetooth/BluetoothSocket.java

+0 −14
Original line number Diff line number Diff line
@@ -515,20 +515,6 @@ public final class BluetoothSocket implements Closeable { 
        return mSocketIS.available();

    }



    /**

     * Wait until the data in sending queue is emptied. A polling version

     * for flush implementation. Used to ensure the writing data afterwards will

     * be packed in new RFCOMM frame.

     *

     * @throws IOException if an i/o error occurs.

     */

    @UnsupportedAppUsage

    /*package*/ void flush() throws IOException {

        if (mSocketOS == null) throw new IOException("flush is called on null OutputStream");

        if (VDBG) Log.d(TAG, "flush: " + mSocketOS);

        mSocketOS.flush();

    }



    /*package*/ int read(byte[] b, int offset, int length) throws IOException {

        int ret = 0;

        if (VDBG) Log.d(TAG, "read in:  " + mSocketIS + " len: " + length);